[jira] Resolved: (LOG4PHP-59) LoggerAppenderConsole is initialized wrong

["Christian Grobmeier (JIRA)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/LOG4PHP-59?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Christian Grobmeier resolved LOG4PHP-59.
----------------------------------------

    Resolution: Fixed

$fp should be a resource and cannot have STOUT assigned.
BUT activateOptions was wrong, cause it never was called in the configurator. That leads to the question of a generic construction of appenders.

However, i fixed the configurator.with rv801073.

Additionally there was bug with closing resourcestreams. I fixed the !== comparisions with "is_resource" too

> LoggerAppenderConsole is initialized wrong
> ------------------------------------------
>
>                 Key: LOG4PHP-59
>                 URL: https://issues.apache.org/jira/browse/LOG4PHP-59
>             Project: Log4php
>          Issue Type: Bug
>          Components: Code
>    Affects Versions: 2.2
>            Reporter: Christian Hammers
>             Fix For: 2.0
>
>
> Hello
> Using    define('LOG4PHP_CONFIGURATOR_CLASS', 'LoggerConfiguratorBasic');   is supposed to configure
> log4php so that it prints on stdout. That currently does not happen as the $fp variable of the LoggerAppenderConsole
> class is never initialized via the setTarget() method.
> The LoggerConfiguratorInit does this with e.g. "log4php.appender.console.target = STDOUT" but here, too, I would
> strongly suggest making stdout the default!
> bye,
> -christian-
> Index: src/main/php/appenders/LoggerAppenderConsole.php
> ===================================================================
> --- src/main/php/appenders/LoggerAppenderConsole.php    (Revision 797819)
> +++ src/main/php/appenders/LoggerAppenderConsole.php    (Arbeitskopie)
> @@ -51,7 +51,7 @@
>          * @var mixed the resource used to open stdout/stderr
>          * @access private         
>          */
> -       protected $fp = false;
> +       protected $fp = STDOUT;
>  
>         /**
>          * Set console target.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.