You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by heary-cao <gi...@git.apache.org> on 2017/07/03 03:11:27 UTC

[GitHub] spark pull request #18174: [SPARK-20950][CORE]add a new config to diskWriteB...

Github user heary-cao commented on a diff in the pull request:

    https://github.com/apache/spark/pull/18174#discussion_r125204174
  
    --- Diff: core/src/main/scala/org/apache/spark/internal/config/package.scala ---
    @@ -335,4 +335,20 @@ package object config {
             "spark.")
           .booleanConf
           .createWithDefault(false)
    +
    +  private[spark] val SHUFFLE_FILE_BUFFER_SIZE =
    +    ConfigBuilder("spark.shuffle.file.buffer")
    +      .intConf
    +      .createWithDefault(32 * 1024)
    +
    +  private[spark] val SHUFFLE_UNSAFE_FILE_OUTPUT_BUFFER_SIZE =
    +    ConfigBuilder("spark.shuffle.unsafe.file.output.buffer")
    --- End diff --
    
    OK,
    thank you for review it.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org