You are viewing a plain text version of this content. The canonical link for it is here.
Posted to test-cvs@httpd.apache.org by do...@apache.org on 2001/10/16 22:33:10 UTC
cvs commit: httpd-test/perl-framework/t TEST.PL
dougm 01/10/16 13:33:10
Modified: perl-framework Makefile.PL
perl-framework/t TEST.PL
Log:
work with Perl 5.005
Revision Changes Path
1.7 +4 -1 httpd-test/perl-framework/Makefile.PL
Index: Makefile.PL
===================================================================
RCS file: /home/cvs/httpd-test/perl-framework/Makefile.PL,v
retrieving revision 1.6
retrieving revision 1.7
diff -u -r1.6 -r1.7
--- Makefile.PL 2001/09/10 04:18:22 1.6
+++ Makefile.PL 2001/10/16 20:33:10 1.7
@@ -1,8 +1,11 @@
use ExtUtils::MakeMaker;
-use 5.006;
+use 5.005;
use lib qw(Apache-Test/lib);
+
+use Apache::Test5005compat;
+
use Apache::TestMM qw(test clean);
use File::Find qw(finddepth);
1.2 +1 -1 httpd-test/perl-framework/t/TEST.PL
Index: TEST.PL
===================================================================
RCS file: /home/cvs/httpd-test/perl-framework/t/TEST.PL,v
retrieving revision 1.1
retrieving revision 1.2
diff -u -r1.1 -r1.2
--- TEST.PL 2001/08/08 16:45:19 1.1
+++ TEST.PL 2001/10/16 20:33:10 1.2
@@ -1,5 +1,5 @@
use strict;
-use warnings FATAL => 'all';
+#use warnings FATAL => 'all';
use lib map { "$_/Apache-Test/lib" } qw(. ..);
Re: cvs commit: httpd-test/perl-framework/t TEST.PL
Posted by "William A. Rowe, Jr." <wr...@covalent.net>.
From: "Doug MacEachern" <do...@covalent.net>
Sent: Wednesday, October 17, 2001 12:14 PM
> On Wed, 17 Oct 2001, William A. Rowe, Jr. wrote:
>
> > It's ok, that patch broke win32 as well... we end up with paths like
>
> wha? the 5.005 compat patch did not change behavior at all. [...]
>
> > C:/httpd-test/perl-framework/C:/httpd-test/perl-framework/t/conf
> >
> > since it doesn't look to Unix like C:/ starts a path.
> >
> > I'd suggest we revert, and find a better solution for Win32.
>
> you must be talking about the patch that added this to Apache/TestRun.pm,
> right??
Yup my bad... and it solves Ken's problem, perhaps.
> BEGIN {
> #Apache likes everything to be in /unix/path/file.ext format
> $INC{'File/Spec.pm'} = __FILE__;
> require File::Spec::Unix;
> @File::Spec::ISA = qw(File::Spec::Unix);
> }
Re: cvs commit: httpd-test/perl-framework/t TEST.PL
Posted by Doug MacEachern <do...@covalent.net>.
On Wed, 17 Oct 2001, William A. Rowe, Jr. wrote:
> It's ok, that patch broke win32 as well... we end up with paths like
wha? the 5.005 compat patch did not change behavior at all. the commit
message says:
backport to 5.005:
- open my $fh, ... => my $fh = Symbol::gensym(); open $fh, ...
- our @foo => use vars qw(@foo)
- create a stub warnings.pm
- complain if File::Spec::Functions does not exist
the latter two don't happen if $] >= 5.006, and there's no way the other
two would change how paths are looked at.
> C:/httpd-test/perl-framework/C:/httpd-test/perl-framework/t/conf
>
> since it doesn't look to Unix like C:/ starts a path.
>
> I'd suggest we revert, and find a better solution for Win32.
you must be talking about the patch that added this to Apache/TestRun.pm,
right??
BEGIN {
#Apache likes everything to be in /unix/path/file.ext format
$INC{'File/Spec.pm'} = __FILE__;
require File::Spec::Unix;
@File::Spec::ISA = qw(File::Spec::Unix);
}
Re: cvs commit: httpd-test/perl-framework/t TEST.PL
Posted by "William A. Rowe, Jr." <wr...@covalent.net>.
From: "Rodent of Unusual Size" <Ke...@Golux.Com>
Sent: Wednesday, October 17, 2001 10:28 AM
> dougm@apache.org wrote:
> >
> > dougm 01/10/16 13:33:10
> >
> > Modified: perl-framework Makefile.PL
> > perl-framework/t TEST.PL
> > Log:
> > work with Perl 5.005
>
> Not entirely, alas:
>
> $ t/TEST
> "$Verbose" is not exported by the File::Spec module at /usr/lib/perl5/5.00503/File/Spec/Unix.pm line 11
> Can't continue after import errors at /usr/lib/perl5/5.00503/File/Spec/Unix.pm line 11
> BEGIN failed--compilation aborted at Apache-Test/lib/Apache/TestRun.pm line 11.
> BEGIN failed--compilation aborted at t/TEST line 8.
It's ok, that patch broke win32 as well... we end up with paths like
C:/httpd-test/perl-framework/C:/httpd-test/perl-framework/t/conf
since it doesn't look to Unix like C:/ starts a path.
I'd suggest we revert, and find a better solution for Win32.
Re: cvs commit: httpd-test/perl-framework/t TEST.PL
Posted by Rodent of Unusual Size <Ke...@Golux.Com>.
Doug MacEachern wrote:
>
> looks more like a File::Spec problem than the test kit,
> what version are you using? for 5.005_03 i installed
> File-Spec-0.82 from CPAN.
0.6; I'm upgrading now..
--
#ken P-)}
Ken Coar, Sanagendamgagwedweinini http://Golux.Com/coar/
Author, developer, opinionist http://Apache-Server.Com/
"All right everyone! Step away from the glowing hamburger!"
Re: cvs commit: httpd-test/perl-framework/t TEST.PL
Posted by Doug MacEachern <do...@covalent.net>.
On Wed, 17 Oct 2001, Rodent of Unusual Size wrote:
> Having some options prefixed with '-' and some not isn't
> exactly intuitive.. :-)
if you look at the test-cvs list and other discussions, you'll see we're
in the middle of fixing that.
> Also, the -clean failure: line 703
> is
>
> opendir(my $dh, $_);
fixed.
you might also hit another problem that we've yet to fix. if t/TEST dies
in the middle of generating conf files, you'll need to:
% find t/conf -name "*.conf" | xargs rm
Re: cvs commit: httpd-test/perl-framework/t TEST.PL
Posted by Rodent of Unusual Size <Ke...@Golux.Com>.
Doug MacEachern wrote:
>
> looks more like a File::Spec problem than the test kit,
> what version are you using?
Okey, upgraded from 0.6 to 0.82; Perl 5.005_03. Now:
$ perl Makefile.PL -apxs /home/coar/web/server/bin/apxs
$ t/TEST
!!! : no test server configured, please ...
$ t/TEST -httpd /home/coar/web/server/bin/httpd
Unknown option: httpd
$ t/TEST httpd /home/coar/web/server/bin/httpd
*** : cannot build c-modules without apxs
waiting for server to warm up...Syntax error on line 239 of ...
:port must be numeric
$ t/TEST -clean
Can't use an undefined value as a symbol reference at
Apache-Test/lib/Apache/TestConfig.pm line 703
$ t/TEST clean
*** : cannot build c-modules without apxs
!!! : no test server configured, please ...
Having some options prefixed with '-' and some not isn't
exactly intuitive.. :-) Also, the -clean failure: line 703
is
opendir(my $dh, $_);
I'm still finding my way through how the tests are done;
this stuff is pretty Deep Magic, and not IOTTMCO! So I'm
not ready to try submitting fixes..
--
#ken P-)}
Ken Coar, Sanagendamgagwedweinini http://Golux.Com/coar/
Author, developer, opinionist http://Apache-Server.Com/
"All right everyone! Step away from the glowing hamburger!"
Re: cvs commit: httpd-test/perl-framework/t TEST.PL
Posted by Doug MacEachern <do...@covalent.net>.
On Wed, 17 Oct 2001, Rodent of Unusual Size wrote:
> $ t/TEST
> "$Verbose" is not exported by the File::Spec module at /usr/lib/perl5/5.00503/File/Spec/Unix.pm line 11
looks more like a File::Spec problem than the test kit, what version are
you using? for 5.005_03 i installed File-Spec-0.82 from CPAN.
% perl -MFile::Spec -le 'print $File::Spec::VERSION'
0.82
Re: cvs commit: httpd-test/perl-framework/t TEST.PL
Posted by Rodent of Unusual Size <Ke...@Golux.Com>.
dougm@apache.org wrote:
>
> dougm 01/10/16 13:33:10
>
> Modified: perl-framework Makefile.PL
> perl-framework/t TEST.PL
> Log:
> work with Perl 5.005
Not entirely, alas:
$ t/TEST
"$Verbose" is not exported by the File::Spec module at /usr/lib/perl5/5.00503/File/Spec/Unix.pm line 11
Can't continue after import errors at /usr/lib/perl5/5.00503/File/Spec/Unix.pm line 11
BEGIN failed--compilation aborted at Apache-Test/lib/Apache/TestRun.pm line 11.
BEGIN failed--compilation aborted at t/TEST line 8.
--
#ken P-)}
Ken Coar, Sanagendamgagwedweinini http://Golux.Com/coar/
Author, developer, opinionist http://Apache-Server.Com/
"All right everyone! Step away from the glowing hamburger!"