[GitHub] [couchdb] jiangphcn commented on issue #2535: Porting spidermonkey60 support to fdb-layer

[GitBox <gi...@apache.org>]

jiangphcn commented on issue #2535: Porting spidermonkey60 support to fdb-layer
URL: https://github.com/apache/couchdb/pull/2535#issuecomment-583978544
 
 
   @wohali thanks for your tips. I added L202-207 for now.  This PR arises when working with @garrensmith on one issue in his Mac environment. We got segment fault on Catalina with spidermonkey 1.8.5 (might be related to 32 bit compatibility issue)and work fine after switching to 60. Knowing that this doesn't happen in every development environment, but it is helpful to add spidermonkey 60 support in fdb-layer branch to continue. 
   
   Thanks for forking `3.x`, and thus we can have `prototype/fdb-layer` to hit `master` soon. In `master` branch, knowing that there is spidermonkey 60 support already. However, still need to merge codes from fdb-layer branch to master branch. If my understanding is correct, this looks like that two small branch rivers (fdb-layer branch and master branch) converge into one big river, and we need to make big river to work fine. The commits on these 2 branches need to be reviewed and some commit in master might need to be replaced/rewritten by commits in fdb-layer branch. I am quite open to have this PR to merge or not. For now, it can leave chance to have spidermonkey 60 support to work with fdb-layer ealier.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services