[GitHub] [spark] cloud-fan commented on a diff in pull request #39564: [SPARK-41990][SQL] Use `FieldReference.column` instead of `apply` in V1 to V2 filter conversion

[GitBox <gi...@apache.org>]

cloud-fan commented on code in PR #39564:
URL: https://github.com/apache/spark/pull/39564#discussion_r1070788648


##########
sql/catalyst/src/main/scala/org/apache/spark/sql/sources/filters.scala:
##########
@@ -74,6 +75,15 @@ sealed abstract class Filter {
    * Converts V1 filter to V2 filter
    */
   private[sql] def toV2: Predicate
+
+  protected def toV2Column(attribute: String): NamedReference = {
+    try {
+      FieldReference(attribute)

Review Comment:
   We should add some comments to explain it.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org