You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@yunikorn.apache.org by GitBox <gi...@apache.org> on 2020/08/12 14:53:40 UTC
[GitHub] [incubator-yunikorn-k8shim] adamantal opened a new pull request #180: [YUNIKORN-368] Pass namespace's parentQueue annotation to application tag
adamantal opened a new pull request #180:
URL: https://github.com/apache/incubator-yunikorn-k8shim/pull/180
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-yunikorn-k8shim] yangwwei merged pull request #180: [YUNIKORN-368] Pass namespace's parentQueue annotation to application tag
Posted by GitBox <gi...@apache.org>.
yangwwei merged pull request #180:
URL: https://github.com/apache/incubator-yunikorn-k8shim/pull/180
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-yunikorn-k8shim] codecov[bot] edited a comment on pull request #180: [YUNIKORN-368] Pass namespace's parentQueue annotation to application tag
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #180:
URL: https://github.com/apache/incubator-yunikorn-k8shim/pull/180#issuecomment-673456779
# [Codecov](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/180?src=pr&el=h1) Report
> Merging [#180](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/180?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/commit/ac345b38432b416aede47e3d51d5e120011c56fd?el=desc) will **decrease** coverage by `0.21%`.
> The diff coverage is `0.00%`.
[](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/180?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #180 +/- ##
==========================================
- Coverage 57.80% 57.58% -0.22%
==========================================
Files 33 32 -1
Lines 3320 3157 -163
==========================================
- Hits 1919 1818 -101
+ Misses 1324 1270 -54
+ Partials 77 69 -8
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/180?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [pkg/cache/context.go](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/180/diff?src=pr&el=tree#diff-cGtnL2NhY2hlL2NvbnRleHQuZ28=) | `32.11% <0.00%> (-0.15%)` | :arrow_down: |
| [pkg/appmgmt/appmgmt.go](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/180/diff?src=pr&el=tree#diff-cGtnL2FwcG1nbXQvYXBwbWdtdC5nbw==) | `28.57% <0.00%> (-2.34%)` | :arrow_down: |
| [pkg/conf/schedulerconf.go](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/180/diff?src=pr&el=tree#diff-cGtnL2NvbmYvc2NoZWR1bGVyY29uZi5nbw==) | `67.10% <0.00%> (-0.85%)` | :arrow_down: |
| [pkg/shim/scheduler.go](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/180/diff?src=pr&el=tree#diff-cGtnL3NoaW0vc2NoZWR1bGVyLmdv) | `80.26% <0.00%> (-0.13%)` | :arrow_down: |
| [pkg/cache/node.go](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/180/diff?src=pr&el=tree#diff-cGtnL2NhY2hlL25vZGUuZ28=) | `84.66% <0.00%> (ø)` | |
| [pkg/common/resource.go](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/180/diff?src=pr&el=tree#diff-cGtnL2NvbW1vbi9yZXNvdXJjZS5nbw==) | `100.00% <0.00%> (ø)` | |
| [pkg/common/si\_helper.go](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/180/diff?src=pr&el=tree#diff-cGtnL2NvbW1vbi9zaV9oZWxwZXIuZ28=) | `60.39% <0.00%> (ø)` | |
| [pkg/common/utils/utils.go](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/180/diff?src=pr&el=tree#diff-cGtnL2NvbW1vbi91dGlscy91dGlscy5nbw==) | `16.16% <0.00%> (ø)` | |
| [pkg/shim/scheduler\_mock.go](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/180/diff?src=pr&el=tree#diff-cGtnL3NoaW0vc2NoZWR1bGVyX21vY2suZ28=) | `85.00% <0.00%> (ø)` | |
| ... and [5 more](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/180/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/180?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/180?src=pr&el=footer). Last update [1056620...e93eea7](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/180?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-yunikorn-k8shim] yangwwei commented on pull request #180: [YUNIKORN-368] Pass namespace's parentQueue annotation to application tag
Posted by GitBox <gi...@apache.org>.
yangwwei commented on pull request #180:
URL: https://github.com/apache/incubator-yunikorn-k8shim/pull/180#issuecomment-685111904
hi @adamantal This PR looks good to me, but I guess we need to merge YUNIKORN-389 to get a clean travis validation first. Let me look at that one and get back to this. Thank you for validating this.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-yunikorn-k8shim] adamantal commented on pull request #180: [YUNIKORN-368] Pass namespace's parentQueue annotation to application tag
Posted by GitBox <gi...@apache.org>.
adamantal commented on pull request #180:
URL: https://github.com/apache/incubator-yunikorn-k8shim/pull/180#issuecomment-686419877
Thanks for merging this in @yangwwei . Filed [YUNIKORN-398](https://issues.apache.org/jira/browse/YUNIKORN-398) for the issue.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-yunikorn-k8shim] codecov[bot] edited a comment on pull request #180: [YUNIKORN-368] Pass namespace's parentQueue annotation to application tag
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #180:
URL: https://github.com/apache/incubator-yunikorn-k8shim/pull/180#issuecomment-673456779
# [Codecov](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/180?src=pr&el=h1) Report
> Merging [#180](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/180?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/commit/ac345b38432b416aede47e3d51d5e120011c56fd?el=desc) will **decrease** coverage by `0.21%`.
> The diff coverage is `0.00%`.
[](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/180?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #180 +/- ##
==========================================
- Coverage 57.80% 57.58% -0.22%
==========================================
Files 33 32 -1
Lines 3320 3157 -163
==========================================
- Hits 1919 1818 -101
+ Misses 1324 1270 -54
+ Partials 77 69 -8
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/180?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [pkg/cache/context.go](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/180/diff?src=pr&el=tree#diff-cGtnL2NhY2hlL2NvbnRleHQuZ28=) | `32.11% <0.00%> (-0.15%)` | :arrow_down: |
| [pkg/appmgmt/appmgmt.go](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/180/diff?src=pr&el=tree#diff-cGtnL2FwcG1nbXQvYXBwbWdtdC5nbw==) | `28.57% <0.00%> (-2.34%)` | :arrow_down: |
| [pkg/conf/schedulerconf.go](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/180/diff?src=pr&el=tree#diff-cGtnL2NvbmYvc2NoZWR1bGVyY29uZi5nbw==) | `67.10% <0.00%> (-0.85%)` | :arrow_down: |
| [pkg/shim/scheduler.go](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/180/diff?src=pr&el=tree#diff-cGtnL3NoaW0vc2NoZWR1bGVyLmdv) | `80.26% <0.00%> (-0.13%)` | :arrow_down: |
| [pkg/cache/node.go](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/180/diff?src=pr&el=tree#diff-cGtnL2NhY2hlL25vZGUuZ28=) | `84.66% <0.00%> (ø)` | |
| [pkg/common/resource.go](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/180/diff?src=pr&el=tree#diff-cGtnL2NvbW1vbi9yZXNvdXJjZS5nbw==) | `100.00% <0.00%> (ø)` | |
| [pkg/common/si\_helper.go](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/180/diff?src=pr&el=tree#diff-cGtnL2NvbW1vbi9zaV9oZWxwZXIuZ28=) | `60.39% <0.00%> (ø)` | |
| [pkg/common/utils/utils.go](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/180/diff?src=pr&el=tree#diff-cGtnL2NvbW1vbi91dGlscy91dGlscy5nbw==) | `16.16% <0.00%> (ø)` | |
| [pkg/shim/scheduler\_mock.go](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/180/diff?src=pr&el=tree#diff-cGtnL3NoaW0vc2NoZWR1bGVyX21vY2suZ28=) | `85.00% <0.00%> (ø)` | |
| ... and [5 more](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/180/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/180?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/180?src=pr&el=footer). Last update [1056620...56a297a](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/180?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-yunikorn-k8shim] codecov[bot] commented on pull request #180: [YUNIKORN-368] Pass namespace's parentQueue annotation to application tag
Posted by GitBox <gi...@apache.org>.
codecov[bot] commented on pull request #180:
URL: https://github.com/apache/incubator-yunikorn-k8shim/pull/180#issuecomment-673456779
# [Codecov](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/180?src=pr&el=h1) Report
> Merging [#180](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/180?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/commit/4d67dac9c857dce3647fe4df79601731917d944d&el=desc) will **increase** coverage by `0.02%`.
> The diff coverage is `0.00%`.
[](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/180?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #180 +/- ##
==========================================
+ Coverage 57.55% 57.58% +0.02%
==========================================
Files 32 32
Lines 3155 3157 +2
==========================================
+ Hits 1816 1818 +2
Misses 1270 1270
Partials 69 69
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/180?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [pkg/cache/context.go](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/180/diff?src=pr&el=tree#diff-cGtnL2NhY2hlL2NvbnRleHQuZ28=) | `32.11% <0.00%> (-0.15%)` | :arrow_down: |
| [pkg/dispatcher/dispatcher.go](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/180/diff?src=pr&el=tree#diff-cGtnL2Rpc3BhdGNoZXIvZGlzcGF0Y2hlci5nbw==) | `87.15% <0.00%> (+1.83%)` | :arrow_up: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/180?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/180?src=pr&el=footer). Last update [4d67dac...f061140](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/180?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-yunikorn-k8shim] codecov[bot] edited a comment on pull request #180: [YUNIKORN-368] Pass namespace's parentQueue annotation to application tag
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #180:
URL: https://github.com/apache/incubator-yunikorn-k8shim/pull/180#issuecomment-673456779
# [Codecov](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/180?src=pr&el=h1) Report
> Merging [#180](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/180?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/commit/9d79d22d65e3efcc87a9debf0def1a12e1d92736?el=desc) will **increase** coverage by `0.64%`.
> The diff coverage is `100.00%`.
[](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/180?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #180 +/- ##
==========================================
+ Coverage 57.93% 58.58% +0.64%
==========================================
Files 33 33
Lines 3295 3303 +8
==========================================
+ Hits 1909 1935 +26
+ Misses 1314 1297 -17
+ Partials 72 71 -1
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/180?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [pkg/cache/context.go](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/180/diff?src=pr&el=tree#diff-cGtnL2NhY2hlL2NvbnRleHQuZ28=) | `37.55% <100.00%> (+5.29%)` | :arrow_up: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/180?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/180?src=pr&el=footer). Last update [9d79d22...8af032a](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/180?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-yunikorn-k8shim] adamantal commented on pull request #180: [YUNIKORN-368] Pass namespace's parentQueue annotation to application tag
Posted by GitBox <gi...@apache.org>.
adamantal commented on pull request #180:
URL: https://github.com/apache/incubator-yunikorn-k8shim/pull/180#issuecomment-685779188
Thanks for checking @yangwwei. Yes indeed, I forgot to add unit tests. Since the quota is also untested I added a test to cover the both. I'll check the Travis results and fix it if something else is missing.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-yunikorn-k8shim] codecov[bot] edited a comment on pull request #180: [YUNIKORN-368] Pass namespace's parentQueue annotation to application tag
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #180:
URL: https://github.com/apache/incubator-yunikorn-k8shim/pull/180#issuecomment-673456779
# [Codecov](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/180?src=pr&el=h1) Report
> Merging [#180](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/180?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/commit/ac345b38432b416aede47e3d51d5e120011c56fd?el=desc) will **decrease** coverage by `0.00%`.
> The diff coverage is `0.00%`.
[](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/180?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #180 +/- ##
==========================================
- Coverage 57.80% 57.79% -0.01%
==========================================
Files 33 33
Lines 3320 3303 -17
==========================================
- Hits 1919 1909 -10
+ Misses 1324 1322 -2
+ Partials 77 72 -5
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/180?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [pkg/cache/context.go](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/180/diff?src=pr&el=tree#diff-cGtnL2NhY2hlL2NvbnRleHQuZ28=) | `31.67% <0.00%> (-0.59%)` | :arrow_down: |
| [pkg/plugin/predicates/predictor.go](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/180/diff?src=pr&el=tree#diff-cGtnL3BsdWdpbi9wcmVkaWNhdGVzL3ByZWRpY3Rvci5nbw==) | `85.36% <ø> (+7.66%)` | :arrow_up: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/180?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/180?src=pr&el=footer). Last update [1056620...56a297a](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/180?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-yunikorn-k8shim] codecov[bot] edited a comment on pull request #180: [YUNIKORN-368] Pass namespace's parentQueue annotation to application tag
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #180:
URL: https://github.com/apache/incubator-yunikorn-k8shim/pull/180#issuecomment-673456779
# [Codecov](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/180?src=pr&el=h1) Report
> Merging [#180](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/180?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/commit/4d67dac9c857dce3647fe4df79601731917d944d&el=desc) will **increase** coverage by `0.02%`.
> The diff coverage is `0.00%`.
[](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/180?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #180 +/- ##
==========================================
+ Coverage 57.55% 57.58% +0.02%
==========================================
Files 32 32
Lines 3155 3157 +2
==========================================
+ Hits 1816 1818 +2
Misses 1270 1270
Partials 69 69
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/180?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [pkg/cache/context.go](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/180/diff?src=pr&el=tree#diff-cGtnL2NhY2hlL2NvbnRleHQuZ28=) | `32.11% <0.00%> (-0.15%)` | :arrow_down: |
| [pkg/dispatcher/dispatcher.go](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/180/diff?src=pr&el=tree#diff-cGtnL2Rpc3BhdGNoZXIvZGlzcGF0Y2hlci5nbw==) | `87.15% <0.00%> (+1.83%)` | :arrow_up: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/180?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/180?src=pr&el=footer). Last update [4d67dac...f061140](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/180?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-yunikorn-k8shim] yangwwei commented on pull request #180: [YUNIKORN-368] Pass namespace's parentQueue annotation to application tag
Posted by GitBox <gi...@apache.org>.
yangwwei commented on pull request #180:
URL: https://github.com/apache/incubator-yunikorn-k8shim/pull/180#issuecomment-685167596
hi @adamantal pls fix the remaining code coverage issue. rest looks good to me. Thanks
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-yunikorn-k8shim] codecov[bot] edited a comment on pull request #180: [YUNIKORN-368] Pass namespace's parentQueue annotation to application tag
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #180:
URL: https://github.com/apache/incubator-yunikorn-k8shim/pull/180#issuecomment-673456779
# [Codecov](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/180?src=pr&el=h1) Report
> Merging [#180](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/180?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/commit/9d79d22d65e3efcc87a9debf0def1a12e1d92736?el=desc) will **decrease** coverage by `0.14%`.
> The diff coverage is `0.00%`.
[](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/180?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #180 +/- ##
==========================================
- Coverage 57.93% 57.79% -0.15%
==========================================
Files 33 33
Lines 3295 3303 +8
==========================================
Hits 1909 1909
- Misses 1314 1322 +8
Partials 72 72
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/180?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [pkg/cache/context.go](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/180/diff?src=pr&el=tree#diff-cGtnL2NhY2hlL2NvbnRleHQuZ28=) | `31.67% <0.00%> (-0.59%)` | :arrow_down: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/180?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/180?src=pr&el=footer). Last update [9d79d22...8af032a](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/180?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-yunikorn-k8shim] yangwwei commented on pull request #180: [YUNIKORN-368] Pass namespace's parentQueue annotation to application tag
Posted by GitBox <gi...@apache.org>.
yangwwei commented on pull request #180:
URL: https://github.com/apache/incubator-yunikorn-k8shim/pull/180#issuecomment-682053841
Hi @adamantal sorry for the late review. The change is pretty straightforward, I only have one comment regarding the structure, basically, I think returning 2 values from `getTagsFromNamespaceAnnotations()` is not very flexible, in case we are going to parse more things from the namespace. I suggest changing this to
```
// update application tags in the AddApplicationRequest based on the namespace annotation
func (ctx *Context) updateApplicationTags(request *interfaces.AddApplicationRequest, namespace string) {
// adding tags to request based on annotations
// include
// - namespace.resourcequota
// - namespace.parentqueue
}
func (ctx *Context) AddApplication(request *interfaces.AddApplicationRequest) interfaces.ManagedApp {
...
updateApplicationTags(request, ns)
...
}
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-yunikorn-k8shim] adamantal commented on pull request #180: [YUNIKORN-368] Pass namespace's parentQueue annotation to application tag
Posted by GitBox <gi...@apache.org>.
adamantal commented on pull request #180:
URL: https://github.com/apache/incubator-yunikorn-k8shim/pull/180#issuecomment-683840990
I have validated this patch. Configurations:
Namespace config:
```yaml
apiVersion: v1
kind: Namespace
metadata:
annotations:
yunikorn.apache.org/parentqueue: "root.special"
name: random
```
The pod:
```yaml
apiVersion: v1
kind: Pod
metadata:
labels:
app: sleep
applicationId: "application-sleep-0001"
namespace: "random"
queue: "root.default"
name: task0
spec:
schedulerName: yunikorn
containers:
- name: sleep-30s
image: "alpine:latest"
command: ["sleep", "30"]
resources:
requests:
cpu: "100m"
memory: "500M"
```
Queue configs:
```yaml
partitions:
- name: default
placementrules:
- name: tag
value: namespace
create: true
parent:
name: tag
value: "namespace.parentqueue"
create: true
queues:
- name: root
submitacl: '*'
queues:
- name: default
submitacl: '*'
- name: special
parent: true
submitacl: '*'
queues:
- name: leaf
```
The application was correctly put into queue `root.special.random`.
Note that:
- the app CRD *has to be turned off* (it is somehow intercepts the basic placement of the application)
- the Travis CI check is currently failing due to [YUNIKORN-389](https://issues.apache.org/jira/browse/YUNIKORN-389)
- I also found a scheduler crash during testing, filed [YUNIKORN-390](https://issues.apache.org/jira/browse/YUNIKORN-390) for that
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-yunikorn-k8shim] codecov[bot] edited a comment on pull request #180: [YUNIKORN-368] Pass namespace's parentQueue annotation to application tag
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #180:
URL: https://github.com/apache/incubator-yunikorn-k8shim/pull/180#issuecomment-673456779
# [Codecov](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/180?src=pr&el=h1) Report
> Merging [#180](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/180?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/commit/ac345b38432b416aede47e3d51d5e120011c56fd?el=desc) will **decrease** coverage by `0.21%`.
> The diff coverage is `0.00%`.
[](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/180?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #180 +/- ##
==========================================
- Coverage 57.80% 57.58% -0.22%
==========================================
Files 33 32 -1
Lines 3320 3157 -163
==========================================
- Hits 1919 1818 -101
+ Misses 1324 1270 -54
+ Partials 77 69 -8
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/180?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [pkg/cache/context.go](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/180/diff?src=pr&el=tree#diff-cGtnL2NhY2hlL2NvbnRleHQuZ28=) | `32.11% <0.00%> (-0.15%)` | :arrow_down: |
| [pkg/appmgmt/appmgmt.go](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/180/diff?src=pr&el=tree#diff-cGtnL2FwcG1nbXQvYXBwbWdtdC5nbw==) | `28.57% <0.00%> (-2.34%)` | :arrow_down: |
| [pkg/conf/schedulerconf.go](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/180/diff?src=pr&el=tree#diff-cGtnL2NvbmYvc2NoZWR1bGVyY29uZi5nbw==) | `67.10% <0.00%> (-0.85%)` | :arrow_down: |
| [pkg/shim/scheduler.go](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/180/diff?src=pr&el=tree#diff-cGtnL3NoaW0vc2NoZWR1bGVyLmdv) | `80.26% <0.00%> (-0.13%)` | :arrow_down: |
| [pkg/cache/node.go](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/180/diff?src=pr&el=tree#diff-cGtnL2NhY2hlL25vZGUuZ28=) | `84.66% <0.00%> (ø)` | |
| [pkg/common/resource.go](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/180/diff?src=pr&el=tree#diff-cGtnL2NvbW1vbi9yZXNvdXJjZS5nbw==) | `100.00% <0.00%> (ø)` | |
| [pkg/common/si\_helper.go](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/180/diff?src=pr&el=tree#diff-cGtnL2NvbW1vbi9zaV9oZWxwZXIuZ28=) | `60.39% <0.00%> (ø)` | |
| [pkg/common/utils/utils.go](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/180/diff?src=pr&el=tree#diff-cGtnL2NvbW1vbi91dGlscy91dGlscy5nbw==) | `16.16% <0.00%> (ø)` | |
| [pkg/shim/scheduler\_mock.go](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/180/diff?src=pr&el=tree#diff-cGtnL3NoaW0vc2NoZWR1bGVyX21vY2suZ28=) | `85.00% <0.00%> (ø)` | |
| ... and [5 more](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/180/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/180?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/180?src=pr&el=footer). Last update [1056620...5ae2631](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/180?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-yunikorn-k8shim] codecov[bot] edited a comment on pull request #180: [YUNIKORN-368] Pass namespace's parentQueue annotation to application tag
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #180:
URL: https://github.com/apache/incubator-yunikorn-k8shim/pull/180#issuecomment-673456779
# [Codecov](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/180?src=pr&el=h1) Report
> Merging [#180](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/180?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/commit/ac345b38432b416aede47e3d51d5e120011c56fd?el=desc) will **decrease** coverage by `0.00%`.
> The diff coverage is `0.00%`.
[](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/180?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #180 +/- ##
==========================================
- Coverage 57.80% 57.79% -0.01%
==========================================
Files 33 33
Lines 3320 3303 -17
==========================================
- Hits 1919 1909 -10
+ Misses 1324 1322 -2
+ Partials 77 72 -5
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/180?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [pkg/cache/context.go](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/180/diff?src=pr&el=tree#diff-cGtnL2NhY2hlL2NvbnRleHQuZ28=) | `31.67% <0.00%> (-0.59%)` | :arrow_down: |
| [pkg/plugin/predicates/predictor.go](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/180/diff?src=pr&el=tree#diff-cGtnL3BsdWdpbi9wcmVkaWNhdGVzL3ByZWRpY3Rvci5nbw==) | `85.36% <ø> (+7.66%)` | :arrow_up: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/180?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/180?src=pr&el=footer). Last update [1056620...56a297a](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/180?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org