You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@beam.apache.org by "Moritz Mack (Jira)" <ji...@apache.org> on 2022/04/20 09:22:00 UTC

[jira] [Commented] (BEAM-14334) Avoid using forkEvery in Spark runner tests

    [ https://issues.apache.org/jira/browse/BEAM-14334?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17524828#comment-17524828 ] 

Moritz Mack commented on BEAM-14334:
------------------------------------

Looks like BEAM-11653 was failing due do a SparkContext related leak that is fixed with this issue.

> Avoid using forkEvery in Spark runner tests
> -------------------------------------------
>
>                 Key: BEAM-14334
>                 URL: https://issues.apache.org/jira/browse/BEAM-14334
>             Project: Beam
>          Issue Type: Improvement
>          Components: runner-spark, testing
>            Reporter: Moritz Mack
>            Assignee: Moritz Mack
>            Priority: P2
>
> Usage of *{color:#FF0000}forkEvery 1{color}* is typically a strong sign of poor quality / bad code and should be avoided: 
>  * It significantly impacts performance when running tests.
>  * And it often hides resource leaks, either in code or worse in the runner itself.



--
This message was sent by Atlassian Jira
(v8.20.7#820007)