[jira] [Updated] (QPID-8604) [Broker-J] Code cleanup: immutable fields, static inner classes, long literals

["Tomas Vavricka (Jira)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/QPID-8604?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Tomas Vavricka updated QPID-8604:
---------------------------------
    Summary: [Broker-J] Code cleanup: immutable fields, static inner classes, long literals  (was: [Broker-J] Broker code cleanup: immutable fields, static inner classes, long literals)

> [Broker-J] Code cleanup: immutable fields, static inner classes, long literals
> ------------------------------------------------------------------------------
>
>                 Key: QPID-8604
>                 URL: https://issues.apache.org/jira/browse/QPID-8604
>             Project: Qpid
>          Issue Type: Improvement
>          Components: Broker-J
>    Affects Versions: qpid-java-broker-8.0.6
>            Reporter: Daniil Kirilyuk
>            Priority: Minor
>             Fix For: qpid-java-broker-9.0.0
>
>
> Following issues are covered with this JIRA:
> 1. Private fields whose values never change once they are initialized either in the declaration of the field or by a constructor should be marked as final. This aids in converting existing classes to immutable classes.
> 2. A non-static inner class has a reference to its outer class, and access to the outer class' fields and methods. That class reference makes the inner class larger and could cause the outer class instance to live in memory longer than necessary.
> 3. There are many places in the broker code where long literals end with lowercase 'l' character mimicking the '1'. They should be replaced with uppercase 'L'. 



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org