You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2022/06/19 17:20:43 UTC

[GitHub] [arrow-rs] viirya commented on a diff in pull request #1910: minor: clarify docstring on `DictionaryArray::lookup_key`

viirya commented on code in PR #1910:
URL: https://github.com/apache/arrow-rs/pull/1910#discussion_r901135825


##########
arrow/src/array/array_dictionary.rs:
##########
@@ -128,7 +128,11 @@ impl<'a, K: ArrowPrimitiveType> DictionaryArray<K> {
         &self.keys
     }
 
-    /// Returns the lookup key by doing reverse dictionary lookup
+    /// If `value` is present in `values` (aka the dictionary),
+    /// returns the coresponding key (index into the `values`

Review Comment:
   typo?
   ```suggestion
       /// returns the corresponding key (index into the `values`
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org