You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@couchdb.apache.org by chewbranca <gi...@git.apache.org> on 2014/11/07 23:26:16 UTC
[GitHub] couchdb-couch pull request: Allow couch_httpd_cors to be disable b...
GitHub user chewbranca opened a pull request:
https://github.com/apache/couchdb-couch/pull/14
Allow couch_httpd_cors to be disable by the calling process
In chttpd we call into couch_httpd for the low level http functions
like send_json. The function couch_httpd:send_response/4 calls out to
couch_httpd_cors, which will cause duplicate CORS headers to be set
when we've already gone through chttpd_cors.
This is a bit of a hack but it's a good temporary measure until we
consolidate couch_httpd and chttpd down to one http stack.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/apache/couchdb-couch 2080-port-cors-to-chttpd
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/couchdb-couch/pull/14.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #14
----
commit d20fb113237da8153386feee2359395d2d07b5d9
Author: Russell Branca <ch...@apache.org>
Date: 2014-11-06T22:53:28Z
Allow couch_httpd_cors to be disable by the calling process
In chttpd we call into couch_httpd for the low level http functions
like send_json. The function couch_httpd:send_response/4 calls out to
couch_httpd_cors, which will cause duplicate CORS headers to be set
when we've already gone through chttpd_cors.
This is a bit of a hack but it's a good temporary measure until we
consolidate couch_httpd and chttpd down to one http stack.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] couchdb-couch pull request: Allow couch_httpd_cors to be disable b...
Posted by nolanlawson <gi...@git.apache.org>.
Github user nolanlawson commented on the pull request:
https://github.com/apache/couchdb-couch/pull/14#issuecomment-108159995
Cool, thanks! :+1:
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] couchdb-couch pull request: Allow couch_httpd_cors to be disable b...
Posted by chewbranca <gi...@git.apache.org>.
Github user chewbranca commented on the pull request:
https://github.com/apache/couchdb-couch/pull/14#issuecomment-108070910
This PR and the companion `chttpd` PR in https://github.com/apache/couchdb-chttpd/pull/8 are both merged.
/cc @rnewson @kxepal @nolanlawson
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] couchdb-couch pull request: Allow couch_httpd_cors to be disable b...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/couchdb-couch/pull/14
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] couchdb-couch pull request: Allow couch_httpd_cors to be disable b...
Posted by chewbranca <gi...@git.apache.org>.
Github user chewbranca commented on the pull request:
https://github.com/apache/couchdb-couch/pull/14#issuecomment-62224753
This is a companion PR to https://github.com/apache/couchdb-chttpd/pull/8.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] couchdb-couch pull request: Allow couch_httpd_cors to be disable b...
Posted by rnewson <gi...@git.apache.org>.
Github user rnewson commented on the pull request:
https://github.com/apache/couchdb-couch/pull/14#issuecomment-107075633
+1 (cc @nolanlawson).
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---