You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@kylin.apache.org by GitBox <gi...@apache.org> on 2019/09/18 12:45:26 UTC
[GitHub] [kylin] codecov-io edited a comment on issue #757: KYLIN-3917: Add
max segment merge span to cleanup intermediate data of cube building
codecov-io edited a comment on issue #757: KYLIN-3917: Add max segment merge span to cleanup intermediate data of cube building
URL: https://github.com/apache/kylin/pull/757#issuecomment-512737154
# [Codecov](https://codecov.io/gh/apache/kylin/pull/757?src=pr&el=h1) Report
> Merging [#757](https://codecov.io/gh/apache/kylin/pull/757?src=pr&el=desc) into [master](https://codecov.io/gh/apache/kylin/commit/199bc17e572652b8a8ec8c4f0c6aab1a2359c1ef?src=pr&el=desc) will **decrease** coverage by `<.01%`.
> The diff coverage is `14.28%`.
[](https://codecov.io/gh/apache/kylin/pull/757?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #757 +/- ##
===========================================
- Coverage 25.7% 25.7% -0.01%
- Complexity 6124 6127 +3
===========================================
Files 1400 1400
Lines 83729 83754 +25
Branches 11740 11746 +6
===========================================
+ Hits 21523 21527 +4
- Misses 60132 60156 +24
+ Partials 2074 2071 -3
```
| [Impacted Files](https://codecov.io/gh/apache/kylin/pull/757?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...c/main/java/org/apache/kylin/cube/CubeManager.java](https://codecov.io/gh/apache/kylin/pull/757/diff?src=pr&el=tree#diff-Y29yZS1jdWJlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9reWxpbi9jdWJlL0N1YmVNYW5hZ2VyLmphdmE=) | `36.67% <0%> (-0.3%)` | `44 <0> (ø)` | |
| [...java/org/apache/kylin/metadata/model/Segments.java](https://codecov.io/gh/apache/kylin/pull/757/diff?src=pr&el=tree#diff-Y29yZS1tZXRhZGF0YS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUva3lsaW4vbWV0YWRhdGEvbW9kZWwvU2VnbWVudHMuamF2YQ==) | `0% <0%> (ø)` | `0 <0> (ø)` | :arrow_down: |
| [.../java/org/apache/kylin/common/KylinConfigBase.java](https://codecov.io/gh/apache/kylin/pull/757/diff?src=pr&el=tree#diff-Y29yZS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2t5bGluL2NvbW1vbi9LeWxpbkNvbmZpZ0Jhc2UuamF2YQ==) | `12.76% <0%> (-0.02%)` | `42 <0> (ø)` | |
| [...a/org/apache/kylin/rest/job/StorageCleanupJob.java](https://codecov.io/gh/apache/kylin/pull/757/diff?src=pr&el=tree#diff-c2VydmVyLWJhc2Uvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2t5bGluL3Jlc3Qvam9iL1N0b3JhZ2VDbGVhbnVwSm9iLmphdmE=) | `64.42% <57.14%> (-0.64%)` | `32 <0> (ø)` | |
| [...ream/core/storage/columnar/ColumnarStoreCache.java](https://codecov.io/gh/apache/kylin/pull/757/diff?src=pr&el=tree#diff-c3RyZWFtLWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2t5bGluL3N0cmVhbS9jb3JlL3N0b3JhZ2UvY29sdW1uYXIvQ29sdW1uYXJTdG9yZUNhY2hlLmphdmE=) | `51.16% <0%> (-3.49%)` | `8% <0%> (ø)` | |
| [...he/kylin/job/impl/threadpool/DefaultScheduler.java](https://codecov.io/gh/apache/kylin/pull/757/diff?src=pr&el=tree#diff-Y29yZS1qb2Ivc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2t5bGluL2pvYi9pbXBsL3RocmVhZHBvb2wvRGVmYXVsdFNjaGVkdWxlci5qYXZh) | `74.41% <0%> (-2.33%)` | `12% <0%> (ø)` | |
| [...eam/core/storage/columnar/DataSegmentFragment.java](https://codecov.io/gh/apache/kylin/pull/757/diff?src=pr&el=tree#diff-c3RyZWFtLWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2t5bGluL3N0cmVhbS9jb3JlL3N0b3JhZ2UvY29sdW1uYXIvRGF0YVNlZ21lbnRGcmFnbWVudC5qYXZh) | `57.37% <0%> (-1.64%)` | `17% <0%> (-1%)` | |
| [.../main/java/org/apache/kylin/cube/CubeInstance.java](https://codecov.io/gh/apache/kylin/pull/757/diff?src=pr&el=tree#diff-Y29yZS1jdWJlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9reWxpbi9jdWJlL0N1YmVJbnN0YW5jZS5qYXZh) | `38.21% <0%> (+0.71%)` | `51% <0%> (+2%)` | :arrow_up: |
| [.../apache/kylin/cube/cuboid/TreeCuboidScheduler.java](https://codecov.io/gh/apache/kylin/pull/757/diff?src=pr&el=tree#diff-Y29yZS1jdWJlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9reWxpbi9jdWJlL2N1Ym9pZC9UcmVlQ3Vib2lkU2NoZWR1bGVyLmphdmE=) | `66.15% <0%> (+2.3%)` | `0% <0%> (ø)` | :arrow_down: |
| [...org/apache/kylin/rest/util/QueryRequestLimits.java](https://codecov.io/gh/apache/kylin/pull/757/diff?src=pr&el=tree#diff-c2VydmVyLWJhc2Uvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2t5bGluL3Jlc3QvdXRpbC9RdWVyeVJlcXVlc3RMaW1pdHMuamF2YQ==) | `40.47% <0%> (+4.76%)` | `6% <0%> (+1%)` | :arrow_up: |
| ... and [1 more](https://codecov.io/gh/apache/kylin/pull/757/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/kylin/pull/757?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/kylin/pull/757?src=pr&el=footer). Last update [199bc17...1085997](https://codecov.io/gh/apache/kylin/pull/757?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services