You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@aurora.apache.org by Reza Motamedi <re...@gmail.com> on 2017/05/12 16:48:20 UTC
Review Request 59231: fix update affinity cache name
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59231/
-----------------------------------------------------------
Review request for Aurora, David McLaughlin, Mehrdad Nurolahzade, Santhosh Kumar Shanmugham, and Zameer Manji.
Repository: aurora
Description
-------
fix update affinity cache name
in a previous review (https://reviews.apache.org/r/58636/) I introduced metrics for BiCache explicit removals and expirations. There I changed the contract to instead of passing _cache size metric name_, I require just the __cache name__. That has already up applied to all usages of Bichae. The update affinitiy patch had a merge conflict that did not pick this change, which leads to metric names such as `update_affinity_cache_size_cache_expiration_removals`, `update_affinity_cache_size_cache_explicit_removals`, `update_affinity_cache_size_cache_removals`, `update_affinity_cache_size_cache_size`.
Diffs
-----
src/main/java/org/apache/aurora/scheduler/updater/UpdaterModule.java 219bb4e2ae1111e61336a6779531288d066f3ea7
Diff: https://reviews.apache.org/r/59231/diff/1/
Testing
-------
Thanks,
Reza Motamedi
Re: Review Request 59231: fix update affinity cache name
Posted by Aurora ReviewBot <wf...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59231/#review174818
-----------------------------------------------------------
Master (b0d24f4) is green with this patch.
./build-support/jenkins/build.sh
However, it appears that it might lack test coverage.
I will refresh this build result if you post a review containing "@ReviewBot retry"
- Aurora ReviewBot
On May 12, 2017, 4:48 p.m., Reza Motamedi wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/59231/
> -----------------------------------------------------------
>
> (Updated May 12, 2017, 4:48 p.m.)
>
>
> Review request for Aurora, David McLaughlin, Mehrdad Nurolahzade, Santhosh Kumar Shanmugham, and Zameer Manji.
>
>
> Repository: aurora
>
>
> Description
> -------
>
> fix update affinity cache name
>
> in a previous review (https://reviews.apache.org/r/58636/) I introduced metrics for BiCache explicit removals and expirations. There I changed the contract to instead of passing _cache size metric name_, I require just the __cache name__. That has already up applied to all usages of Bichae. The update affinitiy patch had a merge conflict that did not pick this change, which leads to metric names such as `update_affinity_cache_size_cache_expiration_removals`, `update_affinity_cache_size_cache_explicit_removals`, `update_affinity_cache_size_cache_removals`, `update_affinity_cache_size_cache_size`.
>
>
> Diffs
> -----
>
> src/main/java/org/apache/aurora/scheduler/updater/UpdaterModule.java 219bb4e2ae1111e61336a6779531288d066f3ea7
>
>
> Diff: https://reviews.apache.org/r/59231/diff/1/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Reza Motamedi
>
>
Re: Review Request 59231: fix update affinity cache name
Posted by Mehrdad Nurolahzade <me...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59231/#review174821
-----------------------------------------------------------
Ship it!
Ship It!
- Mehrdad Nurolahzade
On May 12, 2017, 9:48 a.m., Reza Motamedi wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/59231/
> -----------------------------------------------------------
>
> (Updated May 12, 2017, 9:48 a.m.)
>
>
> Review request for Aurora, David McLaughlin, Mehrdad Nurolahzade, Santhosh Kumar Shanmugham, and Zameer Manji.
>
>
> Repository: aurora
>
>
> Description
> -------
>
> fix update affinity cache name
>
> in a previous review (https://reviews.apache.org/r/58636/) I introduced metrics for BiCache explicit removals and expirations. There I changed the contract to instead of passing _cache size metric name_, I require just the __cache name__. That has already up applied to all usages of Bichae. The update affinitiy patch had a merge conflict that did not pick this change, which leads to metric names such as `update_affinity_cache_size_cache_expiration_removals`, `update_affinity_cache_size_cache_explicit_removals`, `update_affinity_cache_size_cache_removals`, `update_affinity_cache_size_cache_size`.
>
>
> Diffs
> -----
>
> src/main/java/org/apache/aurora/scheduler/updater/UpdaterModule.java 219bb4e2ae1111e61336a6779531288d066f3ea7
>
>
> Diff: https://reviews.apache.org/r/59231/diff/1/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Reza Motamedi
>
>
Re: Review Request 59231: fix update affinity cache name
Posted by Santhosh Kumar Shanmugham <sa...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59231/#review174816
-----------------------------------------------------------
Ship it!
Ship It!
- Santhosh Kumar Shanmugham
On May 12, 2017, 9:48 a.m., Reza Motamedi wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/59231/
> -----------------------------------------------------------
>
> (Updated May 12, 2017, 9:48 a.m.)
>
>
> Review request for Aurora, David McLaughlin, Mehrdad Nurolahzade, Santhosh Kumar Shanmugham, and Zameer Manji.
>
>
> Repository: aurora
>
>
> Description
> -------
>
> fix update affinity cache name
>
> in a previous review (https://reviews.apache.org/r/58636/) I introduced metrics for BiCache explicit removals and expirations. There I changed the contract to instead of passing _cache size metric name_, I require just the __cache name__. That has already up applied to all usages of Bichae. The update affinitiy patch had a merge conflict that did not pick this change, which leads to metric names such as `update_affinity_cache_size_cache_expiration_removals`, `update_affinity_cache_size_cache_explicit_removals`, `update_affinity_cache_size_cache_removals`, `update_affinity_cache_size_cache_size`.
>
>
> Diffs
> -----
>
> src/main/java/org/apache/aurora/scheduler/updater/UpdaterModule.java 219bb4e2ae1111e61336a6779531288d066f3ea7
>
>
> Diff: https://reviews.apache.org/r/59231/diff/1/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Reza Motamedi
>
>
Re: Review Request 59231: fix update affinity cache name
Posted by Stephan Erb <se...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59231/#review174914
-----------------------------------------------------------
Ship it!
Ship It!
- Stephan Erb
On May 12, 2017, 6:48 p.m., Reza Motamedi wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/59231/
> -----------------------------------------------------------
>
> (Updated May 12, 2017, 6:48 p.m.)
>
>
> Review request for Aurora, David McLaughlin, Mehrdad Nurolahzade, Santhosh Kumar Shanmugham, and Zameer Manji.
>
>
> Repository: aurora
>
>
> Description
> -------
>
> fix update affinity cache name
>
> in a previous review (https://reviews.apache.org/r/58636/) I introduced metrics for BiCache explicit removals and expirations. There I changed the contract to instead of passing _cache size metric name_, I require just the __cache name__. That has already up applied to all usages of Bichae. The update affinitiy patch had a merge conflict that did not pick this change, which leads to metric names such as `update_affinity_cache_size_cache_expiration_removals`, `update_affinity_cache_size_cache_explicit_removals`, `update_affinity_cache_size_cache_removals`, `update_affinity_cache_size_cache_size`.
>
>
> Diffs
> -----
>
> src/main/java/org/apache/aurora/scheduler/updater/UpdaterModule.java 219bb4e2ae1111e61336a6779531288d066f3ea7
>
>
> Diff: https://reviews.apache.org/r/59231/diff/1/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Reza Motamedi
>
>
Re: Review Request 59231: fix update affinity cache name
Posted by David McLaughlin <da...@dmclaughlin.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59231/#review174815
-----------------------------------------------------------
Ship it!
Ship It!
- David McLaughlin
On May 12, 2017, 4:48 p.m., Reza Motamedi wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/59231/
> -----------------------------------------------------------
>
> (Updated May 12, 2017, 4:48 p.m.)
>
>
> Review request for Aurora, David McLaughlin, Mehrdad Nurolahzade, Santhosh Kumar Shanmugham, and Zameer Manji.
>
>
> Repository: aurora
>
>
> Description
> -------
>
> fix update affinity cache name
>
> in a previous review (https://reviews.apache.org/r/58636/) I introduced metrics for BiCache explicit removals and expirations. There I changed the contract to instead of passing _cache size metric name_, I require just the __cache name__. That has already up applied to all usages of Bichae. The update affinitiy patch had a merge conflict that did not pick this change, which leads to metric names such as `update_affinity_cache_size_cache_expiration_removals`, `update_affinity_cache_size_cache_explicit_removals`, `update_affinity_cache_size_cache_removals`, `update_affinity_cache_size_cache_size`.
>
>
> Diffs
> -----
>
> src/main/java/org/apache/aurora/scheduler/updater/UpdaterModule.java 219bb4e2ae1111e61336a6779531288d066f3ea7
>
>
> Diff: https://reviews.apache.org/r/59231/diff/1/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Reza Motamedi
>
>