[GitHub] [kvrocks] enjoy-binbin opened a new pull request, #1577: Avoid Write calls when SIADD added_cnt is 0

["enjoy-binbin (via GitHub)" <gi...@apache.org>]

enjoy-binbin opened a new pull request, #1577:
URL: https://github.com/apache/kvrocks/pull/1577

   This may improve performance by 40% in certain case.
   
   Simple benchmarks:
   ```
   src/redis-benchmark -p 6666 -P 100 -n 100000 siadd key 1 2 3
   ```
   
   Before is 95057.03 requests per second.
   After is 135135.14 requests per second.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@kvrocks.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [kvrocks] git-hulk merged pull request #1577: Avoid Write calls when SIADD added_cnt is 0

["git-hulk (via GitHub)" <gi...@apache.org>]

git-hulk merged PR #1577:
URL: https://github.com/apache/kvrocks/pull/1577


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@kvrocks.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [kvrocks] xiaobiaozhao commented on pull request #1577: Avoid Write calls when SIADD added_cnt is 0

["xiaobiaozhao (via GitHub)" <gi...@apache.org>]

xiaobiaozhao commented on PR #1577:
URL: https://github.com/apache/kvrocks/pull/1577#issuecomment-1630981481

   Why such a big performance boost? I don't get that from the logic of the code


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@kvrocks.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org