You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2020/02/06 13:53:29 UTC
[GitHub] [pulsar] slominskir opened a new pull request #6245: Allow Symbolic
Link to Bash Scripts
slominskir opened a new pull request #6245: Allow Symbolic Link to Bash Scripts
URL: https://github.com/apache/pulsar/pull/6245
### Motivation
If a symbolic link is used to access a Pulsar bash script in the bin directory the script may fail to work as the code that determines the working directory assumes the user is accessing the script from the physical path.
### Modifications
I have simply added the option "-P" to the "cd" command at the top of each bash script in the bin directory. This instructs the change directory command to resolve the physical path so that relative paths are calculated properly.
### Verifying this change
I executed the scripts to confirm they still work if user's current working directory contains a symbolic link in it or not. Specifically, a symbolic link in which the directory depth differs now works. For example, if you have a symbolic link on your Desktop or a "latest" link that you can simply update to point to newest version of pulsar as it becomes available.
This change should already by covered by existing tests assuming some tests execute the scripts.
### Does this pull request potentially affect one of the following parts:
Bash Scripts only, nothing else.
### Documentation
Not exactly a new feature and not exactly a bug fix. Just scripts are more robust.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [pulsar] aahmed-se merged pull request #6245: Allow Symbolic Link
to Bash Scripts
Posted by GitBox <gi...@apache.org>.
aahmed-se merged pull request #6245: Allow Symbolic Link to Bash Scripts
URL: https://github.com/apache/pulsar/pull/6245
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [pulsar] slominskir commented on issue #6245: Allow Symbolic Link
to Bash Scripts
Posted by GitBox <gi...@apache.org>.
slominskir commented on issue #6245: Allow Symbolic Link to Bash Scripts
URL: https://github.com/apache/pulsar/pull/6245#issuecomment-582917379
This issue was discussed here:
https://apache-pulsar.slack.com/archives/C5Z4T36F7/p1580920027210400
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services