You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@apisix.apache.org by GitBox <gi...@apache.org> on 2022/03/01 06:04:14 UTC
[GitHub] [apisix] liangliang4ward opened a new pull request #6476: docs: fixed response-rewrite-docs format
liangliang4ward opened a new pull request #6476:
URL: https://github.com/apache/apisix/pull/6476
### What this PR does / why we need it:
<!--- Why is this change required? What problem does it solve? -->
fixed response-rewrite-docs format
<!--- If it fixes an open issue, please link to the issue here. -->
### Pre-submission checklist:
<!--
Please follow the PR manners:
1. Use Draft if the PR is not ready to be reviewed
2. Test is required for the feat/fix PR, unless you have a good reason
3. Doc is required for the feat PR
4. Use a new commit to resolve review instead of `push -f`
5. If you need to resolve merge conflicts after the PR is reviewed, please merge master but do not rebase
6. Use "request review" to notify the reviewer once you have resolved the review
7. Only reviewer can click "Resolve conversation" to mark the reviewer's review resolved
-->
* [ ] Did you explain what problem does this PR solve? Or what new features have been added?
* [ ] Have you added corresponding test cases?
* [ ] Have you modified the corresponding document?
* [ ] Is this PR backward compatible? **If it is not backward compatible, please discuss on the [mailing list](https://github.com/apache/apisix/tree/master#community) first**
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] spacewander merged pull request #6476: docs: fixed zh/response-rewrite.md format
Posted by GitBox <gi...@apache.org>.
spacewander merged pull request #6476:
URL: https://github.com/apache/apisix/pull/6476
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] liangliang4ward commented on a change in pull request #6476: docs: fixed zh/response-rewrite.md format
Posted by GitBox <gi...@apache.org>.
liangliang4ward commented on a change in pull request #6476:
URL: https://github.com/apache/apisix/pull/6476#discussion_r817440749
##########
File path: docs/zh/latest/plugins/response-rewrite.md
##########
@@ -23,19 +23,21 @@ title: response-rewrite
## 目录
-- [**response-rewrite**](#response-rewrite)
+- [**简介**](#简介)
Review comment:
> Agree! We have more people using website 😉
so? remove them?and also other docs?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] spacewander commented on a change in pull request #6476: docs: fixed zh/response-rewrite.md format
Posted by GitBox <gi...@apache.org>.
spacewander commented on a change in pull request #6476:
URL: https://github.com/apache/apisix/pull/6476#discussion_r816494908
##########
File path: docs/zh/latest/plugins/response-rewrite.md
##########
@@ -23,19 +23,21 @@ title: response-rewrite
## 目录
-- [**response-rewrite**](#response-rewrite)
+- [**简介**](#简介)
Review comment:
Maybe we can remove them as we already generate the table of content on the doc site?
https://apisix.apache.org/docs/apisix/plugins/redirect
@juzhiyuan
What about your opinion?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] juzhiyuan commented on a change in pull request #6476: docs: fixed zh/response-rewrite.md format
Posted by GitBox <gi...@apache.org>.
juzhiyuan commented on a change in pull request #6476:
URL: https://github.com/apache/apisix/pull/6476#discussion_r817467759
##########
File path: docs/zh/latest/plugins/response-rewrite.md
##########
@@ -23,19 +23,21 @@ title: response-rewrite
## 目录
-- [**response-rewrite**](#response-rewrite)
+- [**简介**](#简介)
Review comment:
Hi @liangliang4ward, I would prefer to keep this PR as current status and submit a new PR to remove all Outlines from markdown files, @liangliang4ward could you help to do that?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] juzhiyuan commented on a change in pull request #6476: docs: fixed zh/response-rewrite.md format
Posted by GitBox <gi...@apache.org>.
juzhiyuan commented on a change in pull request #6476:
URL: https://github.com/apache/apisix/pull/6476#discussion_r817437549
##########
File path: docs/zh/latest/plugins/response-rewrite.md
##########
@@ -23,19 +23,21 @@ title: response-rewrite
## 目录
-- [**response-rewrite**](#response-rewrite)
+- [**简介**](#简介)
Review comment:
Agree! We have more people using website 😉
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] liangliang4ward commented on a change in pull request #6476: docs: fixed zh/response-rewrite.md format
Posted by GitBox <gi...@apache.org>.
liangliang4ward commented on a change in pull request #6476:
URL: https://github.com/apache/apisix/pull/6476#discussion_r817486958
##########
File path: docs/zh/latest/plugins/response-rewrite.md
##########
@@ -23,19 +23,21 @@ title: response-rewrite
## 目录
-- [**response-rewrite**](#response-rewrite)
+- [**简介**](#简介)
Review comment:
i'd like to
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org