You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@eventmesh.apache.org by mi...@apache.org on 2022/10/27 07:44:07 UTC
[incubator-eventmesh] branch master updated: Update KnativeMessageFactory.java
This is an automated email from the ASF dual-hosted git repository.
mikexue pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-eventmesh.git
The following commit(s) were added to refs/heads/master by this push:
new 2a7e44e0 Update KnativeMessageFactory.java
new ea0e81c7 Merge pull request #1921 from gradyroc/eventmesh-gradyzhou-patch1
2a7e44e0 is described below
commit 2a7e44e0c27bd555c71248bb903fa8f856713842
Author: gradyroc <42...@users.noreply.github.com>
AuthorDate: Wed Oct 26 22:30:20 2022 +0800
Update KnativeMessageFactory.java
line 34 add a NullpointerException check to print a log to increase code robustness
---
.../connector/knative/cloudevent/KnativeMessageFactory.java | 6 ++++++
1 file changed, 6 insertions(+)
diff --git a/eventmesh-connector-plugin/eventmesh-connector-knative/src/main/java/org/apache/eventmesh/connector/knative/cloudevent/KnativeMessageFactory.java b/eventmesh-connector-plugin/eventmesh-connector-knative/src/main/java/org/apache/eventmesh/connector/knative/cloudevent/KnativeMessageFactory.java
index 76cde999..8bb95753 100644
--- a/eventmesh-connector-plugin/eventmesh-connector-knative/src/main/java/org/apache/eventmesh/connector/knative/cloudevent/KnativeMessageFactory.java
+++ b/eventmesh-connector-plugin/eventmesh-connector-knative/src/main/java/org/apache/eventmesh/connector/knative/cloudevent/KnativeMessageFactory.java
@@ -17,6 +17,7 @@
package org.apache.eventmesh.connector.knative.cloudevent;
+import lombok.extern.slf4j.Slf4j;
import org.apache.eventmesh.connector.knative.cloudevent.impl.KnativeMessageWriter;
import java.nio.charset.StandardCharsets;
@@ -24,6 +25,7 @@ import java.util.Properties;
import io.cloudevents.CloudEvent;
+@Slf4j
public final class KnativeMessageFactory {
private KnativeMessageFactory() {
@@ -31,6 +33,10 @@ public final class KnativeMessageFactory {
}
public static String createReader(final CloudEvent message) {
+ if (message.getData() == null) {
+ log.warn("CloudEvent message's data is null.");
+ return "";
+ }
return new String(message.getData().toBytes(), StandardCharsets.UTF_8);
}
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: commits-help@eventmesh.apache.org