You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2022/04/16 14:07:04 UTC
[GitHub] [arrow-rs] andygrove opened a new issue, #1574: protoc failed: Unknown flag: `--experimental_allow_proto3_optional`
andygrove opened a new issue, #1574:
URL: https://github.com/apache/arrow-rs/issues/1574
**Describe the bug**
I get an error when running `cargo test`. This is apparently due to a recent upgrade to post and likely related to having an old protoc installed (I am using `libprotoc 3.11.4`). I am filing this issue to help others that hit the same problem.
```
error: failed to run custom build command for `arrow-flight v12.0.0 (/tmp/arrow-12.0.0.PitgR/apache-arrow-rs-12.0.0/arrow-flight)`
Caused by:
process didn't exit successfully: `/tmp/arrow-12.0.0.PitgR/apache-arrow-rs-12.0.0/target/debug/build/arrow-flight-32d1e9d97d680e87/build-script-build` (exit status: 1)
--- stdout
cargo:rerun-if-changed=../format/Flight.proto
--- stderr
Error: Custom { kind: Other, error: "protoc failed: Unknown flag: --experimental_allow_proto3_optional\n" }
```
**To Reproduce**
Run `cargo test`
**Expected behavior**
Should not fail.
**Additional context**
Add any other context about the problem here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-rs] alamb commented on issue #1574: protoc failed: Unknown flag: `--experimental_allow_proto3_optional`
Posted by GitBox <gi...@apache.org>.
alamb commented on issue #1574:
URL: https://github.com/apache/arrow-rs/issues/1574#issuecomment-1205563935
I think we have concluded this is not a bug but a "feature" of newer versions of prost
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-rs] tustvold commented on issue #1574: protoc failed: Unknown flag: `--experimental_allow_proto3_optional`
Posted by GitBox <gi...@apache.org>.
tustvold commented on issue #1574:
URL: https://github.com/apache/arrow-rs/issues/1574#issuecomment-1100699251
Yes, protoc no longer bundles protoc binaries and instead uses the system versions if available, or builds from source if not - see https://github.com/tokio-rs/prost/pull/610
Unfortunately the arrow-flight specification is using the somewhat new [explicit presence](https://github.com/protocolbuffers/protobuf/blob/main/docs/field_presence.md#how-to-enable-explicit-presence-in-proto3) feature of protobuf, and this will cause issues if compiling with an older version of protoc which doesn't support it.
Perhaps we could check the version of the protoc binary and return a more helpful error message if it is too old 🤔
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-rs] alamb commented on issue #1574: protoc failed: Unknown flag: `--experimental_allow_proto3_optional`
Posted by GitBox <gi...@apache.org>.
alamb commented on issue #1574:
URL: https://github.com/apache/arrow-rs/issues/1574#issuecomment-1384719329
Thanks for the report @XinyuZeng -- if you can contribute such an improvement that would be great ❤️
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-rs] tustvold commented on issue #1574: protoc failed: Unknown flag: `--experimental_allow_proto3_optional`
Posted by GitBox <gi...@apache.org>.
tustvold commented on issue #1574:
URL: https://github.com/apache/arrow-rs/issues/1574#issuecomment-1133612714
FWIW I believe if you uninstall `protobuf-compiler` and have `cmake` installed, prost will automatically compile the `protobuf-compiler` from source.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-rs] alamb closed issue #1574: protoc failed: Unknown flag: `--experimental_allow_proto3_optional`
Posted by GitBox <gi...@apache.org>.
alamb closed issue #1574: protoc failed: Unknown flag: `--experimental_allow_proto3_optional`
URL: https://github.com/apache/arrow-rs/issues/1574
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-rs] Ismail-Maj commented on issue #1574: protoc failed: Unknown flag: `--experimental_allow_proto3_optional`
Posted by GitBox <gi...@apache.org>.
Ismail-Maj commented on issue #1574:
URL: https://github.com/apache/arrow-rs/issues/1574#issuecomment-1133609135
Building protobuf from source solved this problem for me, I had to also uninstall the ubuntu package `protobuf-compiler`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-rs] XinyuZeng commented on issue #1574: protoc failed: Unknown flag: `--experimental_allow_proto3_optional`
Posted by GitBox <gi...@apache.org>.
XinyuZeng commented on issue #1574:
URL: https://github.com/apache/arrow-rs/issues/1574#issuecomment-1383193010
The issue seems still happen today on my AWS Ubuntu 20.04 machine.
> FWIW I believe if you uninstall protobuf-compiler and have cmake installed, prost will automatically compile the protobuf-compiler from source.
Seems like simply uninstall the old protobuf-compiler does not work. I need manually install the newest one globally. Following https://github.com/hyperium/tonic/issues/1047 solved my issue. Probably some instructions can be added to contributing guide to smooth future ramp ups.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org