You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2021/02/21 11:17:19 UTC
[GitHub] [pulsar] yangl opened a new issue #9661: Can we provide a uniform code formatting template like the eclipse-java-google-style.xml and intellij-java-google-style.xml provided in the google style guide
yangl opened a new issue #9661:
URL: https://github.com/apache/pulsar/issues/9661
**Is your enhancement request related to a problem? Please describe.**
Currently we only provide a uniform checkstyle.xml, but we do not provide a uniform code formatter template to format the code, which results in many different lines of code in PR due to different formatting styles.
**Describe the solution you'd like**
1. provide a unified formatter.xml like the eclipse-java-google-style.xml and intellij-java-google-style.xml provided in the google style guide;
2. use the `formatter-maven-plugin` plugin to automatically format the code each time maven is compiled;
3. add git diff in CI to compare whether there is a difference between the files before and after compilation, and reject the merge if it exists;
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] yangl closed issue #9661: Can we provide a uniform code formatting template like the eclipse-java-google-style.xml and intellij-java-google-style.xml provided in the google style guide
Posted by GitBox <gi...@apache.org>.
yangl closed issue #9661:
URL: https://github.com/apache/pulsar/issues/9661
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org