You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by GitBox <gi...@apache.org> on 2020/06/02 11:56:53 UTC

[GitHub] [shardingsphere] menghaoranss opened a new pull request #5891: Fixes error links of scaling document

menghaoranss opened a new pull request #5891:
URL: https://github.com/apache/shardingsphere/pull/5891


   
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [shardingsphere] kimmking merged pull request #5891: Fixes error links of scaling document

Posted by GitBox <gi...@apache.org>.
kimmking merged pull request #5891:
URL: https://github.com/apache/shardingsphere/pull/5891


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [shardingsphere] codecov-commenter commented on pull request #5891: Fixes error links of scaling document

Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on pull request #5891:
URL: https://github.com/apache/shardingsphere/pull/5891#issuecomment-637523044


   # [Codecov](https://codecov.io/gh/apache/shardingsphere/pull/5891?src=pr&el=h1) Report
   > Merging [#5891](https://codecov.io/gh/apache/shardingsphere/pull/5891?src=pr&el=desc) into [master](https://codecov.io/gh/apache/shardingsphere/commit/c31b758f69a1cb1fddcf7a4a9e8cab8b0c168b29&el=desc) will **not change** coverage.
   > The diff coverage is `n/a`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/shardingsphere/pull/5891/graphs/tree.svg?width=650&height=150&src=pr&token=ZvlXpWa7so)](https://codecov.io/gh/apache/shardingsphere/pull/5891?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff            @@
   ##             master    #5891   +/-   ##
   =========================================
     Coverage     53.02%   53.02%           
     Complexity      439      439           
   =========================================
     Files          1181     1181           
     Lines         20756    20756           
     Branches       3735     3735           
   =========================================
     Hits          11006    11006           
     Misses         9072     9072           
     Partials        678      678           
   ```
   
   
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/shardingsphere/pull/5891?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/shardingsphere/pull/5891?src=pr&el=footer). Last update [c31b758...ad4d20a](https://codecov.io/gh/apache/shardingsphere/pull/5891?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [shardingsphere] kimmking commented on a change in pull request #5891: Fixes error links of scaling document

Posted by GitBox <gi...@apache.org>.
kimmking commented on a change in pull request #5891:
URL: https://github.com/apache/shardingsphere/pull/5891#discussion_r433843899



##########
File path: docs/document/content/quick-start/shardingsphere-scaling-quick-start.cn.md
##########
@@ -6,7 +6,7 @@ weight = 3
 
 ## 1. 规则配置
 
-编辑`%SHARDINGSPHERE_SCALING_HOME%\conf\server.yaml`。详情请参见[使用手册](cn/user-manual/shardingsphere-scaling/usage/)。
+编辑`%SHARDINGSPHERE_SCALING_HOME%\conf\server.yaml`。详情请参见[使用手册](/cn/user-manual/shardingsphere-scaling/usage/)。

Review comment:
       use full path:https://shardingsphere.apache.org/document/current/cn/user-manual/shardingsphere-scaling/usage/




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org