You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by GitBox <gi...@apache.org> on 2022/05/13 01:57:08 UTC
[GitHub] [incubator-doris] cambyzju commented on a diff in pull request #9533: [refactor] Refactoring Status static methods to format message using …
cambyzju commented on code in PR #9533:
URL: https://github.com/apache/incubator-doris/pull/9533#discussion_r871939169
##########
be/src/agent/agent_server.cpp:
##########
@@ -120,14 +120,14 @@ void AgentServer::submit_tasks(TAgentResult& agent_result,
TTaskType::type task_type = task.task_type;
int64_t signature = task.signature;
-#define HANDLE_TYPE(t_task_type, work_pool, req_member) \
- case t_task_type: \
- if (task.__isset.req_member) { \
- work_pool->submit_task(task); \
- } else { \
- ret_st = Status::InvalidArgument(strings::Substitute( \
- "task(signature=$0) has wrong request member", signature)); \
- } \
+#define HANDLE_TYPE(t_task_type, work_pool, req_member) \
+ case t_task_type: \
+ if (task.__isset.req_member) { \
+ work_pool->submit_task(task); \
+ } else { \
+ ret_st = Status::InvalidArgument("task(signature={}) has wrong request member", \
Review Comment:
use #req_member to print the real request member, such as 'create_tablet_req', 'drop_tablet_req', and so on, otherwise this error message is still confusing.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org