[jira] [Closed] (WAGON-582) HttpMethodConfiguration#copy() performs a shallow copy only

["Michael Osipov (Jira)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/WAGON-582?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Michael Osipov closed WAGON-582.
--------------------------------
    Resolution: Fixed

Fixed with [c766255c469bd4560d447613a2ff66dc9c5be29c|https://gitbox.apache.org/repos/asf?p=maven-wagon.git;a=commit;h=c766255c469bd4560d447613a2ff66dc9c5be29c].

> HttpMethodConfiguration#copy() performs a shallow copy only
> -----------------------------------------------------------
>
>                 Key: WAGON-582
>                 URL: https://issues.apache.org/jira/browse/WAGON-582
>             Project: Maven Wagon
>          Issue Type: Bug
>          Components: wagon-http
>    Affects Versions: 3.3.4
>            Reporter: Michael Osipov
>            Assignee: Michael Osipov
>            Priority: Major
>             Fix For: 3.4.0
>
>
> The {{copy()}} method does the following: {{copy.setHeaders( getHeaders() );}} same for parameters. It passes the reference of the {{Properties}} object w/o creating a new instance and copying the content. All subsequent instances share those and may modify those.
> To make things worse {{HttpConfiguration.DEFAULT_PUT}} is passed for {{PUT}}. If a previous configuration modified {{http.protocol.expect-continue}} to {{false}} this singleton is modified too.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)