[GitHub] [inlong] gosonzhang commented on a diff in pull request #6184: [INLONG-6181][Agent][Dataproxy][SDK] Support node protocol reporting and query

[GitBox <gi...@apache.org>]

gosonzhang commented on code in PR #6184:
URL: https://github.com/apache/inlong/pull/6184#discussion_r996659288


##########
inlong-dataproxy/dataproxy-source/src/main/java/org/apache/inlong/dataproxy/heartbeat/HeartbeatManager.java:
##########
@@ -79,7 +84,7 @@ public void start() {
     }
 
     @Override
-    public void reportHeartbeat(HeartbeatMsg heartbeat) {
+    public void reportHeartbeat(List<HeartbeatMsg> heartbeat) {

Review Comment:
   Why report multiple heartbeats?
   
   A DataProxy node can start multiple different sources but does not need to construct a heartbeat message for each source



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org