You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@gobblin.apache.org by "ASF GitHub Bot (Jira)" <ji...@apache.org> on 2023/10/26 20:29:00 UTC

[jira] [Work logged] (GOBBLIN-1938) execute bit on destination dirs

     [ https://issues.apache.org/jira/browse/GOBBLIN-1938?focusedWorklogId=887465&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-887465 ]

ASF GitHub Bot logged work on GOBBLIN-1938:
-------------------------------------------

                Author: ASF GitHub Bot
            Created on: 26/Oct/23 20:28
            Start Date: 26/Oct/23 20:28
    Worklog Time Spent: 10m 
      Work Description: arjun4084346 commented on code in PR #3804:
URL: https://github.com/apache/gobblin/pull/3804#discussion_r1373779968


##########
gobblin-data-management/src/main/java/org/apache/gobblin/data/management/copy/ManifestBasedDataset.java:
##########
@@ -128,6 +143,12 @@ public Iterator<FileSet<CopyEntity>> getFileSetIterator(FileSystem targetFs, Cop
           toDelete.add(targetFs.getFileStatus(fileToCopy));
         }
       }
+
+      Properties props = new Properties();
+      props.setProperty(SetPermissionCommitStep.STOP_ON_ERROR_KEY, "true");
+      CommitStep setPermissionCommitStep = new SetPermissionCommitStep(targetFs, ancestorOwnerAndPermissions, props);

Review Comment:
   If dir does not exist, we create it, but we create it with execute bit set. I do not want to not do that, because execute bit may be necessary to do publish.
   So, in this PR, I had to add a post publish step to set the original permission.
   Honestly, the requirement for this work, unsetting execute bit, seems quite odd.





Issue Time Tracking
-------------------

            Worklog Id:     (was: 887465)
    Remaining Estimate: 0h
            Time Spent: 10m

> execute bit on destination dirs
> -------------------------------
>
>                 Key: GOBBLIN-1938
>                 URL: https://issues.apache.org/jira/browse/GOBBLIN-1938
>             Project: Apache Gobblin
>          Issue Type: Bug
>            Reporter: Arjun Singh Bora
>            Priority: Major
>          Time Spent: 10m
>  Remaining Estimate: 0h
>
> Gobblin sets the execute bit on destination directories. Some users do not want it and want exact permissions on the destination side when using ManifestBasedDatasetFinder



--
This message was sent by Atlassian Jira
(v8.20.10#820010)