You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2020/03/04 14:16:20 UTC
[GitHub] [spark] peter-toth opened a new pull request #27791:
[SPARK-30563][SQL] Disable using commit coordinator with NoopDataSource
peter-toth opened a new pull request #27791: [SPARK-30563][SQL] Disable using commit coordinator with NoopDataSource
URL: https://github.com/apache/spark/pull/27791
### What changes were proposed in this pull request?
This PR disables using commit coordinator with `NoopDataSource`.
### Why are the changes needed?
No need for a coordinator in benchmarks.
### Does this PR introduce any user-facing change?
No.
### How was this patch tested?
Existing UTs.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27791: [SPARK-30563][SQL]
Disable using commit coordinator with NoopDataSource
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27791: [SPARK-30563][SQL] Disable using commit coordinator with NoopDataSource
URL: https://github.com/apache/spark/pull/27791#issuecomment-594553641
Merged build finished. Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27791:
[SPARK-30563][SQL] Disable using commit coordinator with NoopDataSource
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27791: [SPARK-30563][SQL] Disable using commit coordinator with NoopDataSource
URL: https://github.com/apache/spark/pull/27791#issuecomment-594553641
Merged build finished. Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27791:
[SPARK-30563][SQL] Disable using commit coordinator with NoopDataSource
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27791: [SPARK-30563][SQL] Disable using commit coordinator with NoopDataSource
URL: https://github.com/apache/spark/pull/27791#issuecomment-594807019
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/119310/
Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27791:
[SPARK-30563][SQL] Disable using commit coordinator with NoopDataSource
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27791: [SPARK-30563][SQL] Disable using commit coordinator with NoopDataSource
URL: https://github.com/apache/spark/pull/27791#issuecomment-594807008
Merged build finished. Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27791: [SPARK-30563][SQL]
Disable using commit coordinator with NoopDataSource
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27791: [SPARK-30563][SQL] Disable using commit coordinator with NoopDataSource
URL: https://github.com/apache/spark/pull/27791#issuecomment-594807008
Merged build finished. Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] peter-toth commented on issue #27791: [SPARK-30563][SQL]
Disable using commit coordinator with NoopDataSource
Posted by GitBox <gi...@apache.org>.
peter-toth commented on issue #27791: [SPARK-30563][SQL] Disable using commit coordinator with NoopDataSource
URL: https://github.com/apache/spark/pull/27791#issuecomment-595665872
Thanks @MaxGekk @HyukjinKwon.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] peter-toth commented on issue #27791: [SPARK-30563][SQL]
Disable using commit coordinator with NoopDataSource
Posted by GitBox <gi...@apache.org>.
peter-toth commented on issue #27791: [SPARK-30563][SQL] Disable using commit coordinator with NoopDataSource
URL: https://github.com/apache/spark/pull/27791#issuecomment-594548640
cc @MaxGekk
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon closed pull request #27791: [SPARK-30563][SQL]
Disable using commit coordinator with NoopDataSource
Posted by GitBox <gi...@apache.org>.
HyukjinKwon closed pull request #27791: [SPARK-30563][SQL] Disable using commit coordinator with NoopDataSource
URL: https://github.com/apache/spark/pull/27791
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27791:
[SPARK-30563][SQL] Disable using commit coordinator with NoopDataSource
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27791: [SPARK-30563][SQL] Disable using commit coordinator with NoopDataSource
URL: https://github.com/apache/spark/pull/27791#issuecomment-594553648
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/24050/
Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on issue #27791: [SPARK-30563][SQL]
Disable using commit coordinator with NoopDataSource
Posted by GitBox <gi...@apache.org>.
SparkQA commented on issue #27791: [SPARK-30563][SQL] Disable using commit coordinator with NoopDataSource
URL: https://github.com/apache/spark/pull/27791#issuecomment-594552796
**[Test build #119310 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/119310/testReport)** for PR 27791 at commit [`9d37ddb`](https://github.com/apache/spark/commit/9d37ddbf33383133c257ccdc1c825b23a4e65625).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon edited a comment on issue #27791:
[SPARK-30563][SQL] Disable using commit coordinator with NoopDataSource
Posted by GitBox <gi...@apache.org>.
HyukjinKwon edited a comment on issue #27791: [SPARK-30563][SQL] Disable using commit coordinator with NoopDataSource
URL: https://github.com/apache/spark/pull/27791#issuecomment-595551516
Merged to master and branch-3.0.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27791: [SPARK-30563][SQL]
Disable using commit coordinator with NoopDataSource
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27791: [SPARK-30563][SQL] Disable using commit coordinator with NoopDataSource
URL: https://github.com/apache/spark/pull/27791#issuecomment-594807019
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/119310/
Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon commented on issue #27791: [SPARK-30563][SQL]
Disable using commit coordinator with NoopDataSource
Posted by GitBox <gi...@apache.org>.
HyukjinKwon commented on issue #27791: [SPARK-30563][SQL] Disable using commit coordinator with NoopDataSource
URL: https://github.com/apache/spark/pull/27791#issuecomment-595551516
Merged to master.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27791: [SPARK-30563][SQL]
Disable using commit coordinator with NoopDataSource
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27791: [SPARK-30563][SQL] Disable using commit coordinator with NoopDataSource
URL: https://github.com/apache/spark/pull/27791#issuecomment-594553648
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/24050/
Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on issue #27791:
[SPARK-30563][SQL] Disable using commit coordinator with NoopDataSource
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on issue #27791: [SPARK-30563][SQL] Disable using commit coordinator with NoopDataSource
URL: https://github.com/apache/spark/pull/27791#issuecomment-594552796
**[Test build #119310 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/119310/testReport)** for PR 27791 at commit [`9d37ddb`](https://github.com/apache/spark/commit/9d37ddbf33383133c257ccdc1c825b23a4e65625).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on issue #27791: [SPARK-30563][SQL]
Disable using commit coordinator with NoopDataSource
Posted by GitBox <gi...@apache.org>.
SparkQA commented on issue #27791: [SPARK-30563][SQL] Disable using commit coordinator with NoopDataSource
URL: https://github.com/apache/spark/pull/27791#issuecomment-594804974
**[Test build #119310 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/119310/testReport)** for PR 27791 at commit [`9d37ddb`](https://github.com/apache/spark/commit/9d37ddbf33383133c257ccdc1c825b23a4e65625).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org