[jira] [Commented] (OAK-4714) Reindexing should only happen in async mode for a mix mode index definition

["Alex Parvulescu (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/OAK-4714?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15464282#comment-15464282 ] 

Alex Parvulescu commented on OAK-4714:
--------------------------------------

{quote}
I think this might lead to unexpected behaviors when re-indexing is being done due to index def changes. I think a consistent result set (even if it's older) is easier to reason with than with mixed results.
Moreover, I feel that re-indexing is a not-so-frequently occurring administrative task - and stale results during that period might be acceptable.
{quote}
+1

I'm a bit confused about the patch. Currently there are 2 behaviors enforced by the {{MissingIndexProviderStrategy}}:
* sync index: will trigger a reindex
* async index: will skip index round by failing the commit ('async' mode does not set the reindex flag AFAIKT)

OAK-4641 was about providing a way to ping an async indexer about (close to) real time content changes, to help take some action about refreshing the index data, but it would still be a sort of an async index, so if the current scenario happens, wouldn't it be better to treat this as an 'async editor missing' issue? ie. on 'sync' mode ignore, on 'async' mode throw commit exception as usual? So the only code changes would require updating the {{MissingIndexProviderStrategy}} to verify the {{isReindexingModeMatching}} and bail early if it's the case.


> Reindexing should only happen in async mode for a mix mode index definition
> ---------------------------------------------------------------------------
>
>                 Key: OAK-4714
>                 URL: https://issues.apache.org/jira/browse/OAK-4714
>             Project: Jackrabbit Oak
>          Issue Type: Bug
>          Components: core
>    Affects Versions: 1.5.8
>            Reporter: Chetan Mehrotra
>            Priority: Minor
>             Fix For: 1.6
>
>         Attachments: OAK-4714-v1.patch
>
>
> With OAK-4641 support was added for enabling use of same index definition for both async and sync mode. This causes issue for reindexing as with this change it would be attempted for both modes.
> Instead for a mixed mode index definition reindexing should be bounded to only one of the modes and only for that mode reindexing should be performed. 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)