You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@ignite.apache.org by GitBox <gi...@apache.org> on 2021/12/06 13:09:34 UTC

[GitHub] [ignite-3] ibessonov commented on a change in pull request #492: IGNITE-16056 Using polymorphic schema leads to ClassCastException

ibessonov commented on a change in pull request #492:
URL: https://github.com/apache/ignite-3/pull/492#discussion_r762991508



##########
File path: modules/configuration/src/main/java/org/apache/ignite/internal/configuration/util/ConfigurationNotificationsUtil.java
##########
@@ -622,7 +622,7 @@ public Void visitNamedListNode(String key, NamedListNode<?> newNamedList) {
 
                 for (String name : newNamedList.namedListKeys()) {
                     DynamicConfiguration<InnerNode, ?> newNodeCfg =
-                            (DynamicConfiguration<InnerNode, ?>) namedDynamicConfig(cfgNode, key).get(name);
+                            (DynamicConfiguration<InnerNode, ?>) namedDynamicConfig(cfgNode, key).touchMembers().get(name);

Review comment:
       I don't think you should do it on every iteration




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org