You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@apisix.apache.org by GitBox <gi...@apache.org> on 2020/05/06 09:39:46 UTC

[GitHub] [incubator-apisix] Akayeshmantha opened a new pull request #1551: [WIP] buffer log requests.

Akayeshmantha opened a new pull request #1551:
URL: https://github.com/apache/incubator-apisix/pull/1551


   
   ### Summary
   Add buffer support sys log.
   
   
   ### Issues resolved
   
   Fix #1500


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-apisix] Akayeshmantha commented on pull request #1551: Buffer log requests.

Posted by GitBox <gi...@apache.org>.
Akayeshmantha commented on pull request #1551:
URL: https://github.com/apache/incubator-apisix/pull/1551#issuecomment-624555680


   @membphis  @moonming  PR is ready to review.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-apisix] Akayeshmantha commented on pull request #1551: Buffer sys log requests.

Posted by GitBox <gi...@apache.org>.
Akayeshmantha commented on pull request #1551:
URL: https://github.com/apache/incubator-apisix/pull/1551#issuecomment-625186156


   @membphis  done.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-apisix] membphis commented on pull request #1551: Buffer sys log requests.

Posted by GitBox <gi...@apache.org>.
membphis commented on pull request #1551:
URL: https://github.com/apache/incubator-apisix/pull/1551#issuecomment-625645289


   @Akayeshmantha we need to remove stale objects from `syslog`. we can use a new PR to do this.
   
   I have created a related issue: https://github.com/apache/incubator-apisix/issues/1554


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-apisix] membphis commented on pull request #1551: Buffer sys log requests.

Posted by GitBox <gi...@apache.org>.
membphis commented on pull request #1551:
URL: https://github.com/apache/incubator-apisix/pull/1551#issuecomment-625022144


   please use `make lint` to check the code style of your code:
   
   ```
   +luacheck -q apisix
   Checking apisix/plugins/syslog.lua                4 warnings
       apisix/plugins/syslog.lua:21:7: unused variable pairs
       apisix/plugins/syslog.lua:22:7: unused variable type
       apisix/plugins/syslog.lua:23:7: unused variable table
       apisix/plugins/syslog.lua:102:49: accessing undefined variable entry
   ```


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org