[GitHub] [buildstream] gtristan commented on issue #1588: 1.6: CI failing due to Python 3.6

[GitBox <gi...@apache.org>]

gtristan commented on issue #1588:
URL: https://github.com/apache/buildstream/issues/1588#issuecomment-1039900873


   I'm a bit torn here... as I'd really like to just ditch this problem even if we're just delaying the problem.
   
   I think that *ultimately* we should have separate frozen requirements.txt files for each supported python version, since this kind of incompatibility *can* happen and so it *will* most probably happen again one day.
   
   > ... I consider it acceptable to drop official Python 3.6 support even in the 1.6.x branch. With this I don't mean that we start using Python 3.7-only constructs in the 1.6.x branch, the branch would be expected to continue working with Python 3.6....
   
   This is a bit uncomfortable, if we don't test with 3.6 then it means we can accidentally let 3.7-only constructs sneak in accidentally.
   
   With all that said, while I'd *prefer* to have 3.6 supported in the `bst-1` branch, I'm not against dropping it given it's EOL and BuildStream is also very unlikely to break with 3.6 anyway - so the fastest way forward is probably to just go ahead and drop 3.6 from CI.
   
   I'd say overall let's just go ahead with this.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@buildstream.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org