You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@lucene.apache.org by "Ishan Chattopadhyaya (Jira)" <ji...@apache.org> on 2020/08/23 10:13:00 UTC
[jira] [Commented] (SOLR-14651) Metrics history could disable
itself better
[ https://issues.apache.org/jira/browse/SOLR-14651?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17182644#comment-17182644 ]
Ishan Chattopadhyaya commented on SOLR-14651:
---------------------------------------------
[~dsmiley], does this need additional ref guide instructions on how to disable metrics history API?
> Metrics history could disable itself better
> -------------------------------------------
>
> Key: SOLR-14651
> URL: https://issues.apache.org/jira/browse/SOLR-14651
> Project: Solr
> Issue Type: Improvement
> Components: metrics
> Reporter: David Smiley
> Assignee: David Smiley
> Priority: Minor
> Fix For: 8.7
>
> Time Spent: 50m
> Remaining Estimate: 0h
>
> The MetricsHistoryHandler should disable itself better than it does. It will create a SolrRrdBackendFactory (which has an ExecutorService / thread pool) when it should not when the plugin is disabled. Furthermore, I think this should be disabled by default in tests, as it's excessive machinery that don't matter to 99.9% of tests. This will help our tests run more efficiently.
> While working on other issues, I also occasionally saw a thread leak failure with the RRD being the leaked threads. I see that in "close", we don't _wait_ for the executor to actually shut down but it should.
> CC [~ab]
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org