[GitHub] [fineract] reluxa commented on a diff in pull request #3302: FINERACT-1926: Add external id validation for buyback

["reluxa (via GitHub)" <gi...@apache.org>]

reluxa commented on code in PR #3302:
URL: https://github.com/apache/fineract/pull/3302#discussion_r1259595335


##########
fineract-investor/src/main/java/org/apache/fineract/investor/service/ExternalAssetOwnersWriteServiceImpl.java:
##########
@@ -98,12 +98,22 @@ public CommandProcessingResult buybackLoanByLoanId(JsonCommand command) {
         LocalDate settlementDate = getSettlementDateFromJson(json);
         ExternalId externalId = getTransferExternalIdFromJson(json);
         validateSettlementDate(settlementDate);
+        validateExternalId(externalId);

Review Comment:
   Probably it is just me but I don't get why the external id validation is not required for the sale. 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@fineract.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org