[jira] [Commented] (SLING-8853) Develop an Active variant of ResourceQueue and make it available as possible queue.provider for ForwardDistributionAgentFactory

["Ashish Chopra (Jira)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/SLING-8853?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16980149#comment-16980149 ] 

Ashish Chopra commented on SLING-8853:
--------------------------------------

In the scope of this issue:
* an Active variant of {{ResourceQueue}} has been developed by extending this as {{ActiveResourceQueue}}
* visibility of {{SimpleDistributionQueueProcessor}} has been changed from {{package}} to {{public}}
* {{ResourceQueueProvider}} has been updated to add an instance of {{SimpleDistributionQueueProcessor}} as queue-processor for {{ActiveResourceQueue}} which is a non-concurrent and single-instance {{Runnable}} running on Sling Commons Scheduler
* {{ForwardDistributionAgentFactory}} has been updated to provide "Resource backed" as a valid {{queue.provider}}.
* {{ResourceQueueProviderFactory}} has been updated to be a OSGi configuration factory, creating the Active or Passive {{ResourceQueue}} instances based on installed configuration.

The patch is as at  [^0001-SLING-8853-Adds-ActiveResourceQueue-and-makes-it-ava.patch].

[~marett], [~mpetria], the tests are TBD. I'd be adding them and raising a PR post your initial feedback on the proposed changeset. Thanks!

> Develop an Active variant of ResourceQueue and make it available as possible queue.provider for ForwardDistributionAgentFactory
> -------------------------------------------------------------------------------------------------------------------------------
>
>                 Key: SLING-8853
>                 URL: https://issues.apache.org/jira/browse/SLING-8853
>             Project: Sling
>          Issue Type: Improvement
>          Components: Content Distribution
>            Reporter: Ashish Chopra
>            Priority: Major
>             Fix For: Content Distribution Core 0.4.2
>
>         Attachments: 0001-SLING-8853-Adds-ActiveResourceQueue-and-makes-it-ava.patch
>
>
> Via SLING-7754, a JCR Resource-backed queue [0] implementation was developed for usecases where a queue processor wasn't required, {{ResourceQueue}} implementation is currently {{PASSIVE}}.
> Given above, it is not possible to leverage {{ResourceQueue}} as a {{queue.provider}} for {{DistributionAgents}} created via {{ForwardDistributionAgentFactory}} [1].
> This issue aims to add an "Active" variant of Resource backed queues and provide it as an option for {{ForwardDistributionAgentFactory}}.
> [0] https://github.com/apache/sling-org-apache-sling-distribution-core/blob/master/src/main/java/org/apache/sling/distribution/queue/impl/resource/ResourceQueue.java
> [1] https://github.com/apache/sling-org-apache-sling-distribution-core/blob/deb3d2ae33c4f4678c8503091a9fffdbb141e569/src/main/java/org/apache/sling/distribution/agent/impl/ForwardDistributionAgentFactory.java#L171-L178



--
This message was sent by Atlassian Jira
(v8.3.4#803005)