You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2020/11/11 11:07:11 UTC
[GitHub] [spark] ulysses-you opened a new pull request #30333: [SPARK-32240][SQL] Use URL to parse url string
ulysses-you opened a new pull request #30333:
URL: https://github.com/apache/spark/pull/30333
<!--
Thanks for sending a pull request! Here are some tips for you:
1. If this is your first time, please read our contributor guidelines: https://spark.apache.org/contributing.html
2. Ensure you have added or run the appropriate tests for your PR: https://spark.apache.org/developer-tools.html
3. If the PR is unfinished, add '[WIP]' in your PR title, e.g., '[WIP][SPARK-XXXX] Your PR title ...'.
4. Be sure to keep the PR description updated to reflect all changes.
5. Please write your PR title to summarize what this PR proposes.
6. If possible, provide a concise example to reproduce the issue for a faster review.
7. If you want to add a new configuration, please read the guideline first for naming configurations in
'core/src/main/scala/org/apache/spark/internal/config/ConfigEntry.scala'.
-->
### What changes were proposed in this pull request?
<!--
Please clarify what changes you are proposing. The purpose of this section is to outline the changes and how this PR fixes the issue.
If possible, please consider writing useful notes for better and faster reviews in your PR. See the examples below.
1. If you refactor some codes with changing classes, showing the class hierarchy will help reviewers.
2. If you fix some SQL features, you can provide some references of other DBMSes.
3. If there is design documentation, please add the link.
4. If there is a discussion in the mailing list, please add the link.
-->
Change `URI` back to `URL`.
The issue JIRA [SPARK-32240](https://issues.apache.org/jira/browse/SPARK-32240).
Some history [#14008](https://github.com/apache/spark/pull/14008) and [#14488](https://github.com/apache/spark/pull/14488).
### Why are the changes needed?
<!--
Please clarify why the changes are needed. For instance,
1. If you propose a new API, clarify the use case for a new API.
2. If you fix a bug, you can clarify why it is a bug.
-->
```
select parse_url('https://a.b.c/index.php?params1=a|b¶ms2=x', 'HOST')
-- before this PR
null
-- after this PR
a.b.c
```
Hive also use `URL` to parse url string.
### Does this PR introduce _any_ user-facing change?
<!--
Note that it means *any* user-facing change including all aspects such as the documentation fix.
If yes, please clarify the previous behavior and the change this PR proposes - provide the console output, description and/or an example to show the behavior difference if possible.
If possible, please also clarify if this is a user-facing change compared to the released Spark versions or within the unreleased branches such as master.
If no, write 'No'.
-->
Yes, correct the result.
### How was this patch tested?
<!--
If tests were added, say they were added here. Please make sure to add some test cases that check the changes thoroughly including negative and positive cases if possible.
If it was tested in a way different from regular unit tests, please clarify how you tested step by step, ideally copy and paste-able, so that other reviewers can test and check, and descendants can verify in the future.
If tests were not added, please describe why they were not added and/or why it was difficult to add.
-->
Add test.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #30333: [SPARK-32240][SQL] Use URL to parse url string
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #30333:
URL: https://github.com/apache/spark/pull/30333#issuecomment-725425781
Kubernetes integration test status success
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/35538/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] ulysses-you commented on pull request #30333: [SPARK-32240][SQL] Use URL to parse url string
Posted by GitBox <gi...@apache.org>.
ulysses-you commented on pull request #30333:
URL: https://github.com/apache/spark/pull/30333#issuecomment-728949600
OK, will do it.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #30333: [SPARK-32240][SQL] Use URL to parse url string
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #30333:
URL: https://github.com/apache/spark/pull/30333#issuecomment-725362628
**[Test build #130932 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/130932/testReport)** for PR 30333 at commit [`f62e88b`](https://github.com/apache/spark/commit/f62e88ba760283ecba2773a2fa97e6a8b361fa92).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] ulysses-you commented on pull request #30333: [SPARK-32240][SQL] Use URL to parse url string
Posted by GitBox <gi...@apache.org>.
ulysses-you commented on pull request #30333:
URL: https://github.com/apache/spark/pull/30333#issuecomment-725737710
@srowen Yeah, that's a Hive compatible issue. I always want to eliminate such issue in first thought because of our case. But I agree with your point that it's not a valid url, seems we can close both PR and JIRA.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #30333: [SPARK-32240][SQL] Use URL to parse url string
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #30333:
URL: https://github.com/apache/spark/pull/30333#issuecomment-725523119
**[Test build #130932 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/130932/testReport)** for PR 30333 at commit [`f62e88b`](https://github.com/apache/spark/commit/f62e88ba760283ecba2773a2fa97e6a8b361fa92).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #30333: [SPARK-32240][SQL] Use URL to parse url string
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #30333:
URL: https://github.com/apache/spark/pull/30333#issuecomment-725524416
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] cloud-fan commented on pull request #30333: [SPARK-32240][SQL] Use URL to parse url string
Posted by GitBox <gi...@apache.org>.
cloud-fan commented on pull request #30333:
URL: https://github.com/apache/spark/pull/30333#issuecomment-728903610
I think so. @ulysses-you can you create a sub-task in https://issues.apache.org/jira/browse/SPARK-33275? thanks!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #30333: [SPARK-32240][SQL] Use URL to parse url string
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #30333:
URL: https://github.com/apache/spark/pull/30333#issuecomment-725362628
**[Test build #130932 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/130932/testReport)** for PR 30333 at commit [`f62e88b`](https://github.com/apache/spark/commit/f62e88ba760283ecba2773a2fa97e6a8b361fa92).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #30333: [SPARK-32240][SQL] Use URL to parse url string
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #30333:
URL: https://github.com/apache/spark/pull/30333#issuecomment-725414780
Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/35538/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #30333: [SPARK-32240][SQL] Use URL to parse url string
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #30333:
URL: https://github.com/apache/spark/pull/30333#issuecomment-725425810
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] srowen commented on pull request #30333: [SPARK-32240][SQL] Use URL to parse url string
Posted by GitBox <gi...@apache.org>.
srowen commented on pull request #30333:
URL: https://github.com/apache/spark/pull/30333#issuecomment-725463336
As in the JIRA, that's not quite a valid http URI. I realize the issue is Hive compatibility, but, changing this behavior may break code in other ways. I'd rather do the right-er thing here all else equal and leave it.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #30333: [SPARK-32240][SQL] Use URL to parse url string
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #30333:
URL: https://github.com/apache/spark/pull/30333#issuecomment-725524416
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] ulysses-you closed pull request #30333: [SPARK-32240][SQL] Use URL to parse url string
Posted by GitBox <gi...@apache.org>.
ulysses-you closed pull request #30333:
URL: https://github.com/apache/spark/pull/30333
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #30333: [SPARK-32240][SQL] Use URL to parse url string
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #30333:
URL: https://github.com/apache/spark/pull/30333#issuecomment-725425810
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] ulysses-you commented on pull request #30333: [SPARK-32240][SQL] Use URL to parse url string
Posted by GitBox <gi...@apache.org>.
ulysses-you commented on pull request #30333:
URL: https://github.com/apache/spark/pull/30333#issuecomment-728704359
BTW, do we need throw exception in `ANSI` mode if we accept a no-vaild url instead of return null ? cc @srowen @cloud-fan
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org