[GitHub] [spark] rdblue commented on a change in pull request #26929: [SPARK-30289][SQL] DSv2's partitioning should not accept nested columns

[GitBox <gi...@apache.org>]

rdblue commented on a change in pull request #26929: [SPARK-30289][SQL] DSv2's partitioning should not accept nested columns
URL: https://github.com/apache/spark/pull/26929#discussion_r359115511
 
 

 ##########
 File path: sql/catalyst/src/main/scala/org/apache/spark/sql/connector/catalog/V1Table.scala
 ##########
 @@ -78,6 +78,8 @@ private[sql] case class V1Table(v1Table: CatalogTable) extends Table {
       partitions += spec.asTransform
     }
 
+    import org.apache.spark.sql.connector.catalog.CatalogV2Implicits.TransformHelper
+    partitions.validatePartitionColumns()
 
 Review comment:
   I agree that v1 tables should throw an exception if nested columns are used because it wasn't supported in v1, but there is no need to disallow nested columns in all v2 sources.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org