You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@mesos.apache.org by Jie Yu <yu...@gmail.com> on 2014/08/25 20:32:26 UTC
Review Request 25030: Replaced PKG_CHECK_MODULES with AC_CHECKs in
configure.ac.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25030/
-----------------------------------------------------------
Review request for mesos, Benjamin Hindman and Timothy St. Clair.
Bugs: MESOS-1727
https://issues.apache.org/jira/browse/MESOS-1727
Repository: mesos-git
Description
-------
See summary and ticket. Some people suggested that PKG_CHECK_MODULES is considered harmful.
Diffs
-----
configure.ac 996c21d52a731744058bba76040a8aa454dd8b5c
Diff: https://reviews.apache.org/r/25030/diff/
Testing
-------
./bootstrap.sh
./configure
Thanks,
Jie Yu
Re: Review Request 25030: Replaced PKG_CHECK_MODULES with AC_CHECKs in
configure.ac.
Posted by Jie Yu <yu...@gmail.com>.
> On Aug. 26, 2014, 12:38 a.m., Timothy St. Clair wrote:
> > configure.ac, line 407
> > <https://reviews.apache.org/r/25030/diff/1/?file=668368#file668368line407>
> >
> > Can we just do the compile check?
I will add a TODO for using AX_CXX_CHECK_LIB once we resolve the legal issue. For now, I'll just use the old patch and check for _init.
- Jie
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25030/#review51468
-----------------------------------------------------------
On Aug. 25, 2014, 11:29 p.m., Jie Yu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/25030/
> -----------------------------------------------------------
>
> (Updated Aug. 25, 2014, 11:29 p.m.)
>
>
> Review request for mesos, Benjamin Hindman and Timothy St. Clair.
>
>
> Bugs: MESOS-1727
> https://issues.apache.org/jira/browse/MESOS-1727
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> See summary and ticket. Some people suggested that PKG_CHECK_MODULES is considered harmful.
>
>
> Diffs
> -----
>
> configure.ac 996c21d52a731744058bba76040a8aa454dd8b5c
> m4/ax_cxx_check_lib.m4 PRE-CREATION
>
> Diff: https://reviews.apache.org/r/25030/diff/
>
>
> Testing
> -------
>
> ./bootstrap.sh
> ./configure
>
>
> Thanks,
>
> Jie Yu
>
>
Re: Review Request 25030: Replaced PKG_CHECK_MODULES with AC_CHECKs in
configure.ac.
Posted by "Timothy St. Clair" <ts...@redhat.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25030/#review51468
-----------------------------------------------------------
configure.ac
<https://reviews.apache.org/r/25030/#comment89816>
Can we just do the compile check?
- Timothy St. Clair
On Aug. 25, 2014, 11:29 p.m., Jie Yu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/25030/
> -----------------------------------------------------------
>
> (Updated Aug. 25, 2014, 11:29 p.m.)
>
>
> Review request for mesos, Benjamin Hindman and Timothy St. Clair.
>
>
> Bugs: MESOS-1727
> https://issues.apache.org/jira/browse/MESOS-1727
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> See summary and ticket. Some people suggested that PKG_CHECK_MODULES is considered harmful.
>
>
> Diffs
> -----
>
> configure.ac 996c21d52a731744058bba76040a8aa454dd8b5c
> m4/ax_cxx_check_lib.m4 PRE-CREATION
>
> Diff: https://reviews.apache.org/r/25030/diff/
>
>
> Testing
> -------
>
> ./bootstrap.sh
> ./configure
>
>
> Thanks,
>
> Jie Yu
>
>
Re: Review Request 25030: Replaced PKG_CHECK_MODULES with AC_CHECKs in
configure.ac.
Posted by Jie Yu <yu...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25030/
-----------------------------------------------------------
(Updated Aug. 25, 2014, 11:29 p.m.)
Review request for mesos, Benjamin Hindman and Timothy St. Clair.
Changes
-------
Using AX_CXX_CHECK_LIB
Tested on my mac:
PROTOBUF_JAR=/tmp/protobuf-2.5.0/java/protobuf.jar CC=gcc-4.8 CXX=g++-4.8 ../../../mesos/configure --prefix=/Users/jyu/workspace/mesos-dist/default --with-protobuf=/opt/twitter --disable-python
Bugs: MESOS-1727
https://issues.apache.org/jira/browse/MESOS-1727
Repository: mesos-git
Description
-------
See summary and ticket. Some people suggested that PKG_CHECK_MODULES is considered harmful.
Diffs (updated)
-----
configure.ac 996c21d52a731744058bba76040a8aa454dd8b5c
m4/ax_cxx_check_lib.m4 PRE-CREATION
Diff: https://reviews.apache.org/r/25030/diff/
Testing
-------
./bootstrap.sh
./configure
Thanks,
Jie Yu
Re: Review Request 25030: Replaced PKG_CHECK_MODULES with AC_CHECKs in
configure.ac.
Posted by Jie Yu <yu...@gmail.com>.
> On Aug. 25, 2014, 6:38 p.m., Benjamin Hindman wrote:
> > configure.ac, line 407
> > <https://reviews.apache.org/r/25030/diff/1/?file=668368#file668368line407>
> >
> > Is there one that is?
Added a new m4 which checks cxx libs.
- Jie
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25030/#review51421
-----------------------------------------------------------
On Aug. 25, 2014, 6:32 p.m., Jie Yu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/25030/
> -----------------------------------------------------------
>
> (Updated Aug. 25, 2014, 6:32 p.m.)
>
>
> Review request for mesos, Benjamin Hindman and Timothy St. Clair.
>
>
> Bugs: MESOS-1727
> https://issues.apache.org/jira/browse/MESOS-1727
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> See summary and ticket. Some people suggested that PKG_CHECK_MODULES is considered harmful.
>
>
> Diffs
> -----
>
> configure.ac 996c21d52a731744058bba76040a8aa454dd8b5c
>
> Diff: https://reviews.apache.org/r/25030/diff/
>
>
> Testing
> -------
>
> ./bootstrap.sh
> ./configure
>
>
> Thanks,
>
> Jie Yu
>
>
Re: Review Request 25030: Replaced PKG_CHECK_MODULES with AC_CHECKs in
configure.ac.
Posted by Benjamin Hindman <be...@berkeley.edu>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25030/#review51421
-----------------------------------------------------------
Ship it!
configure.ac
<https://reviews.apache.org/r/25030/#comment89738>
Is there one that is?
- Benjamin Hindman
On Aug. 25, 2014, 6:32 p.m., Jie Yu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/25030/
> -----------------------------------------------------------
>
> (Updated Aug. 25, 2014, 6:32 p.m.)
>
>
> Review request for mesos, Benjamin Hindman and Timothy St. Clair.
>
>
> Bugs: MESOS-1727
> https://issues.apache.org/jira/browse/MESOS-1727
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> See summary and ticket. Some people suggested that PKG_CHECK_MODULES is considered harmful.
>
>
> Diffs
> -----
>
> configure.ac 996c21d52a731744058bba76040a8aa454dd8b5c
>
> Diff: https://reviews.apache.org/r/25030/diff/
>
>
> Testing
> -------
>
> ./bootstrap.sh
> ./configure
>
>
> Thanks,
>
> Jie Yu
>
>