You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@mxnet.apache.org by GitBox <gi...@apache.org> on 2019/01/23 18:40:08 UTC

[GitHub] edisongustavo commented on a change in pull request #13957: Always go through cmake/ChooseBlas.cmake, now we only execute this lo…

edisongustavo commented on a change in pull request #13957: Always go through cmake/ChooseBlas.cmake, now we only execute this lo…
URL: https://github.com/apache/incubator-mxnet/pull/13957#discussion_r250321515
 
 

 ##########
 File path: CMakeLists.txt
 ##########
 @@ -294,8 +294,8 @@ else()
   add_definitions(-DMXNET_USE_NCCL=0)
 endif()
 
+include(cmake/ChooseBlas.cmake)
 
 Review comment:
   Yes, as @lebeg mentioned this change will do nothing in the current state of the code, so this PR doesn't bring anything to the table.
   
   I am currently working on making linking with BLAS a little bit easier, specially on Windows.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services