[GitHub] syed commented on a change in pull request #1940: CLOUDSTACK-9781:ACS records ID in events tables instead of UUID.

[gi...@git.apache.org]

syed commented on a change in pull request #1940: CLOUDSTACK-9781:ACS records ID in events tables instead of UUID.
URL: https://github.com/apache/cloudstack/pull/1940#discussion_r122211201
 
 

 ##########
 File path: api/src/org/apache/cloudstack/api/command/user/template/CreateTemplateCmd.java
 ##########
 @@ -293,7 +293,7 @@ public void create() throws ResourceAllocationException {
     @Override
     public void execute() {
         CallContext.current().setEventDetails(
-            "Template Id: " + getEntityId() + ((getSnapshotId() == null) ? " from volume Id: " + getVolumeId() : " from snapshot Id: " + getSnapshotId()));
+            "Template Id: " + getEntityUuid() + ((getSnapshotId() == null) ? " from volume Id: " + this._uuidMgr.getUuid(Volume.class,getVolumeId()) : " from snapshot Id: " + this._uuidMgr.getUuid(VirtualMachineTemplate.class,getSnapshotId())));
         VirtualMachineTemplate template = null;
 
 Review comment:
   Should be `Snapshot.class`, can you also please check if other entity types match correctly?
 
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services