[GitHub] [nifi-minifi-cpp] adam-markovics commented on a change in pull request #1198: MINIFICPP-1664 - Unnecessary RTIMULib.ini file is created

[GitBox <gi...@apache.org>]

adam-markovics commented on a change in pull request #1198:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1198#discussion_r727790479



##########
File path: extensions/sensors/SensorBase.cpp
##########
@@ -51,11 +51,15 @@ void SensorBase::initialize() {
 }
 
 void SensorBase::onSchedule(const std::shared_ptr<core::ProcessContext>& /*context*/, const std::shared_ptr<core::ProcessSessionFactory>& /*sessionFactory*/) {
-  imu = std::unique_ptr<RTIMU>(RTIMU::createIMU(&settings));
-  if (imu) {
-    imu->IMUInit();
-    imu->setGyroEnable(true);
-    imu->setAccelEnable(true);
+  // Deferred instantiation of RTIMUSettings, because it can create a file "RTIMULib.ini" in the working directory.
+  // SensorBase is instantiated when creating the manifest.
+  settings_ = std::make_unique<RTIMUSettings>();

Review comment:
       The file is not created if the processor is not scheduled. Creating the manifest calls the constructor, but does not schedule the processor. I don't think it is possible to avoid file creation if the processor is actually used.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org