You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2020/04/15 17:43:40 UTC
[GitHub] [flink] killboard opened a new pull request #11760: [docs] Fix
build.sh --flink-version interpretation to 1.xx.x releases
killboard opened a new pull request #11760: [docs] Fix build.sh --flink-version interpretation to 1.xx.x releases
URL: https://github.com/apache/flink/pull/11760
## What is the purpose of the change
* This pull request fixes interpretation of `--flink-version` parameter to 1.xx.x release (e.g 1.10.0 version) in `build.sh` script. The fixes adjusts the `sed` function to consider all digits of version so a `1.10.0` release is now being considered as `110`. Without this fix the `--hadoop-version` is being required because the release `1.10.0` was being considered as `11` that is less than `18` that requires `--hadoop-version` as parameter.
* This PR adjust too a description of flink version in readme to follow the pattern `x.xx.xx` for releases.
## Brief change log
- *Fix sed replacement causing error in 1.xx.xx release versions causing version 1.10.0 being considered as 11 instead 110 so requering haddop as parameter*
- *Improves semantic of flink version description to be according the current release format Flink 1.xx.xx instead Flink-1.x*
## Documentation
- Does this pull request introduce a new feature? (no)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] killboard commented on issue #11760: [docs][typos] Fix
build.sh --flink-version interpretation to 1.xx.x releases
Posted by GitBox <gi...@apache.org>.
killboard commented on issue #11760: [docs][typos] Fix build.sh --flink-version interpretation to 1.xx.x releases
URL: https://github.com/apache/flink/pull/11760#issuecomment-614292121
@flinkbot approve description
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #11760: [docs][typos]
Fix build.sh --flink-version interpretation to 1.xx.x releases
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #11760: [docs][typos] Fix build.sh --flink-version interpretation to 1.xx.x releases
URL: https://github.com/apache/flink/pull/11760#issuecomment-614195359
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "3ee6ff0da32567a0e053d046795aa9d52a060d6c",
"status" : "PENDING",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/160433543",
"triggerID" : "3ee6ff0da32567a0e053d046795aa9d52a060d6c",
"triggerType" : "PUSH"
}, {
"hash" : "3ee6ff0da32567a0e053d046795aa9d52a060d6c",
"status" : "PENDING",
"url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7542",
"triggerID" : "3ee6ff0da32567a0e053d046795aa9d52a060d6c",
"triggerType" : "PUSH"
}, {
"hash" : "3ee6ff0da32567a0e053d046795aa9d52a060d6c",
"status" : "PENDING",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/160433543",
"triggerID" : "614285883",
"triggerType" : "MANUAL"
} ]
}-->
## CI report:
* 3ee6ff0da32567a0e053d046795aa9d52a060d6c Travis: [PENDING](https://travis-ci.com/github/flink-ci/flink/builds/160433543) Azure: [PENDING](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7542)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] killboard commented on issue #11760: [docs][typos] Fix
build.sh --flink-version interpretation to 1.xx.x releases
Posted by GitBox <gi...@apache.org>.
killboard commented on issue #11760: [docs][typos] Fix build.sh --flink-version interpretation to 1.xx.x releases
URL: https://github.com/apache/flink/pull/11760#issuecomment-614291261
@flinkbot
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot commented on issue #11760: [docs] Fix build.sh
--flink-version interpretation to 1.xx.x releases
Posted by GitBox <gi...@apache.org>.
flinkbot commented on issue #11760: [docs] Fix build.sh --flink-version interpretation to 1.xx.x releases
URL: https://github.com/apache/flink/pull/11760#issuecomment-614183879
Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
to review your pull request. We will use this comment to track the progress of the review.
## Automated Checks
Last check on commit 3ee6ff0da32567a0e053d046795aa9d52a060d6c (Wed Apr 15 17:46:45 UTC 2020)
**Warnings:**
* Documentation files were touched, but no `.zh.md` files: Update Chinese documentation or file Jira ticket.
* **Invalid pull request title: No valid Jira ID provided**
<sub>Mention the bot in a comment to re-run the automated checks.</sub>
## Review Progress
* ❓ 1. The [description] looks good.
* ❓ 2. There is [consensus] that the contribution should go into to Flink.
* ❓ 3. Needs [attention] from.
* ❓ 4. The change fits into the overall [architecture].
* ❓ 5. Overall code [quality] is good.
Please see the [Pull Request Review Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full explanation of the review process.<details>
The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required <summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot approve description` to approve one or more aspects (aspects: `description`, `consensus`, `architecture` and `quality`)
- `@flinkbot approve all` to approve all aspects
- `@flinkbot approve-until architecture` to approve everything until `architecture`
- `@flinkbot attention @username1 [@username2 ..]` to require somebody's attention
- `@flinkbot disapprove architecture` to remove an approval you gave earlier
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #11760: [docs] Fix
build.sh --flink-version interpretation to 1.xx.x releases
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #11760: [docs] Fix build.sh --flink-version interpretation to 1.xx.x releases
URL: https://github.com/apache/flink/pull/11760#issuecomment-614195359
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "3ee6ff0da32567a0e053d046795aa9d52a060d6c",
"status" : "PENDING",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/160433543",
"triggerID" : "3ee6ff0da32567a0e053d046795aa9d52a060d6c",
"triggerType" : "PUSH"
}, {
"hash" : "3ee6ff0da32567a0e053d046795aa9d52a060d6c",
"status" : "PENDING",
"url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7542",
"triggerID" : "3ee6ff0da32567a0e053d046795aa9d52a060d6c",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 3ee6ff0da32567a0e053d046795aa9d52a060d6c Travis: [PENDING](https://travis-ci.com/github/flink-ci/flink/builds/160433543) Azure: [PENDING](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7542)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #11760: [docs][typos]
Fix build.sh --flink-version interpretation to 1.xx.x releases
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #11760: [docs][typos] Fix build.sh --flink-version interpretation to 1.xx.x releases
URL: https://github.com/apache/flink/pull/11760#issuecomment-614195359
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "3ee6ff0da32567a0e053d046795aa9d52a060d6c",
"status" : "SUCCESS",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/160433543",
"triggerID" : "3ee6ff0da32567a0e053d046795aa9d52a060d6c",
"triggerType" : "PUSH"
}, {
"hash" : "3ee6ff0da32567a0e053d046795aa9d52a060d6c",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7542",
"triggerID" : "3ee6ff0da32567a0e053d046795aa9d52a060d6c",
"triggerType" : "PUSH"
}, {
"hash" : "3ee6ff0da32567a0e053d046795aa9d52a060d6c",
"status" : "SUCCESS",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/160433543",
"triggerID" : "614285883",
"triggerType" : "MANUAL"
} ]
}-->
## CI report:
* 3ee6ff0da32567a0e053d046795aa9d52a060d6c Travis: [SUCCESS](https://travis-ci.com/github/flink-ci/flink/builds/160433543) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7542)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #11760: [docs][typos]
Fix build.sh --flink-version interpretation to 1.xx.x releases
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #11760: [docs][typos] Fix build.sh --flink-version interpretation to 1.xx.x releases
URL: https://github.com/apache/flink/pull/11760#issuecomment-614195359
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "3ee6ff0da32567a0e053d046795aa9d52a060d6c",
"status" : "SUCCESS",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/160433543",
"triggerID" : "3ee6ff0da32567a0e053d046795aa9d52a060d6c",
"triggerType" : "PUSH"
}, {
"hash" : "3ee6ff0da32567a0e053d046795aa9d52a060d6c",
"status" : "PENDING",
"url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7542",
"triggerID" : "3ee6ff0da32567a0e053d046795aa9d52a060d6c",
"triggerType" : "PUSH"
}, {
"hash" : "3ee6ff0da32567a0e053d046795aa9d52a060d6c",
"status" : "SUCCESS",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/160433543",
"triggerID" : "614285883",
"triggerType" : "MANUAL"
} ]
}-->
## CI report:
* 3ee6ff0da32567a0e053d046795aa9d52a060d6c Travis: [SUCCESS](https://travis-ci.com/github/flink-ci/flink/builds/160433543) Azure: [PENDING](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7542)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot commented on issue #11760: [docs] Fix build.sh
--flink-version interpretation to 1.xx.x releases
Posted by GitBox <gi...@apache.org>.
flinkbot commented on issue #11760: [docs] Fix build.sh --flink-version interpretation to 1.xx.x releases
URL: https://github.com/apache/flink/pull/11760#issuecomment-614195359
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "3ee6ff0da32567a0e053d046795aa9d52a060d6c",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "3ee6ff0da32567a0e053d046795aa9d52a060d6c",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 3ee6ff0da32567a0e053d046795aa9d52a060d6c UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] killboard commented on issue #11760: [docs][typos] Fix
build.sh --flink-version interpretation to 1.xx.x releases
Posted by GitBox <gi...@apache.org>.
killboard commented on issue #11760: [docs][typos] Fix build.sh --flink-version interpretation to 1.xx.x releases
URL: https://github.com/apache/flink/pull/11760#issuecomment-614285883
@flinkbot run travis
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services