You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Joe McDonnell (Code Review)" <ge...@cloudera.org> on 2023/06/02 03:02:27 UTC
[Impala-ASF-CR] IMPALA-10262: RPM/DEB Packaging Support
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/18939 )
Change subject: IMPALA-10262: RPM/DEB Packaging Support
......................................................................
Patch Set 6:
(2 comments)
I think this is looking pretty good. I haven't tried it locally with the latest revision.
I would like to think about unifying the calculation of the dependency packages.
For ongoing development / functionality, how do we keep this tested / working? That doesn't necessarily have to happen in this change. One option would be to add code that creates a separate set of docker images by installing this package (rather than our usual process), and then we modify our dockerised tests to run with the modified images. If all of that got checked in, then it could be run periodically.
http://gerrit.cloudera.org:8080/#/c/18939/6/CMakeLists.txt
File CMakeLists.txt:
http://gerrit.cloudera.org:8080/#/c/18939/6/CMakeLists.txt@574
PS6, Line 574: if (EXISTS "/etc/redhat-release")
: set(IMPALA_LINUX_ID_FILE "/etc/redhat-release")
: elseif (EXISTS "/etc/os-release")
: set(IMPALA_LINUX_ID_FILE "/etc/os-release")
: elseif (EXISTS "/etc/issue")
: set(IMPALA_LINUX_ID_FILE "/etc/issue")
I noticed recently that /etc/os-release is available on all the distributions we support and I was going to replace lsb_release with /etc/os-release. Some of that work may end up being useful for this location as well. I was thinking there could be a script in bin/cmake_aux that essentially does this:
OS_NAME=$(source /etc/os-release && echo "$ID")
OS_VERSION=$(source /etc/os-release && echo "$VERSION_ID")
Either way, I think your logic would work fine for now.
http://gerrit.cloudera.org:8080/#/c/18939/6/CMakeLists.txt@613
PS6, Line 613: set(CPACK_RPM_PACKAGE_AUTOREQPROV " no")
: set(CPACK_RPM_PACKAGE_RELOCATABLE TRUE)
: set(CPACK_RPM_PACKAGE_REQUIRES
: "cyrus-sasl-gssapi, cyrus-sasl-plain, krb5-workstation, openldap-devel, tzdata")
Ideally, this would match the docker/install_os_packages.sh logic almost exactly (without the debug tools). If we changed that script to calculate the package list as a first step (before installing / verifying), then we could have an option that dumps the list of packages after that step and then exits. This CMake code could call that and feed its output into the list of requires here?
To be specific:
1. This list is already a bit out of date. We have some logic for Redhat 8 that adds glibc-langpack-en/langpacks-en to fix a couple Unicode things. We added a requirement on hostname. The docker images may have slightly different requirements, but if we could stick to a single list I think it will be more likely to stay up to date.
2. Do we need a dependency on Java? If so, which version?
--
To view, visit http://gerrit.cloudera.org:8080/18939
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I64419fd400fe8d233dac016b6306157fe9461d82
Gerrit-Change-Number: 18939
Gerrit-PatchSet: 6
Gerrit-Owner: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com>
Gerrit-Reviewer: Xiang Yang <yx...@126.com>
Gerrit-Comment-Date: Fri, 02 Jun 2023 03:02:27 +0000
Gerrit-HasComments: Yes