You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@thrift.apache.org by vgotra <gi...@git.apache.org> on 2017/01/22 17:37:53 UTC
[GitHub] thrift pull request #1163: Update of Apache Thrift .Net Core lib
GitHub user vgotra opened a pull request:
https://github.com/apache/thrift/pull/1163
Update of Apache Thrift .Net Core lib
Changes to library:
- Updated tutorial (added samples of usage of multiplexed protocol to server and client side and other)
- Added framed transport to client side and implementation of framed transport to server
- Updated information related to build of thrift application with CMake, Visual Studio 2017, XCode
- Updated information related to build and usage of Thrift .Net Core library
- Added SDK versions to project for easy usage of different versions of .NET Core SDK
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/vgotra/thrift master
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/thrift/pull/1163.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1163
----
commit 078c88e407bc1273ff9336373e7e29b3c87e808a
Author: Volodymyr Gotra <vg...@gmail.com>
Date: 2017-01-16T00:34:28Z
Added framed transport, updated docs, updated global.json with SDKversion
commit 9dfef2c263c16b603cb15f81eb7acb2262598c8d
Author: Volodymyr Gotra <vg...@gmail.com>
Date: 2017-01-16T01:59:28Z
Added usage to multiplexer to tutorial
commit d4b6f44fb3497d2cdc934a4cebb98c4d971bbc49
Author: Volodymyr Gotra <vg...@gmail.com>
Date: 2017-01-16T02:03:15Z
Changed sdk to current sdk 1.0.0-preview2-1-003177
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] thrift issue #1163: Update of Apache Thrift .Net Core lib
Posted by Jens-G <gi...@git.apache.org>.
Github user Jens-G commented on the issue:
https://github.com/apache/thrift/pull/1163
http://thrift.apache.org/docs/HowToContribute
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] thrift pull request #1163: THRIFT-4039: Update of Apache Thrift .Net Core li...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/thrift/pull/1163
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] thrift issue #1163: THRIFT-4039: Update of Apache Thrift .Net Core lib
Posted by vgotra <gi...@git.apache.org>.
Github user vgotra commented on the issue:
https://github.com/apache/thrift/pull/1163
Hi @Jens-G
It seems that we have first less-more stable version of .Net Core SDK/CLI and .NET Core runtime. Also it is possible to create and run unit and integration tests with .Net Core now.
So, I want to start work on unit tests (maybe also on integration tests) and upgrade library to current stable version of .Net Core.
The only question for me - how do you build libraries on build server and also how I can find some basic help about how to do that. It will be good to know to avoid issues with changes.
Also it will be great to understand how do you include some new frameworks into Thrift.exe generator to easy include generation of .Net Core generator into official Thrift.exe generator - some people asked me recently how to build it because .Net Core generator still not included into Thrift.exe.
P.S. As always I will create task in Apache Jira for new pull request )
Thanks
Volodymyr
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] thrift issue #1163: THRIFT-4039: Update of Apache Thrift .Net Core lib
Posted by vgotra <gi...@git.apache.org>.
Github user vgotra commented on the issue:
https://github.com/apache/thrift/pull/1163
Hi @Jens-G
Added pull request with changes described in Jira task and in pull request.
Later after stabilizing and release of .NET Standard 2.0 I will create new request with migration to latest stable .NET Core SDK.
Thanks
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] thrift issue #1163: THRIFT-4039: Update of Apache Thrift .Net Core lib
Posted by Jens-G <gi...@git.apache.org>.
Github user Jens-G commented on the issue:
https://github.com/apache/thrift/pull/1163
> because .Net Core generator still not included into Thrift.exe.
It's included in trunk, not in 0.10. The release was already at the door so I didn't want to pollute it with a newly included target that may need some time to be thorougly tested and stable. It will be in the next release. When you build the compiler from trunk, you get it right now.
> The only question for me - how do you build libraries on build server and also how I can find some basic help about how to do that. It will be good to know to avoid issues with changes.
Automake scripts do still work, and to my knowledge it is also included in the CMake scripts.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---