[GitHub] fabianmenges commented on issue #4738: [SqlLab] 1-click tab closing in SqlLab

[GitBox <gi...@apache.org>]

fabianmenges commented on issue #4738: [SqlLab] 1-click tab closing in SqlLab
URL: https://github.com/apache/incubator-superset/pull/4738#issuecomment-378047817
 
 
   This is cool, does it make sense to just get rid of the drop down menu and move the "close" button to where the drop down is (the right side)? 
   The drop down contains only 2 elements that are not already on the main page, `rename tab` and `hide tool bar`. Rename tab could be triggered when you click on the name of the tab. `Hide toolbar` could just be a control on the page. Overall I'm still in favor of just getting rid of tabs in SQL labs all together and using the tabs of my browser.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services