[GitHub] [superset] AAfghahi commented on a change in pull request #14741: fix: Additional ResultSet tests

[GitBox <gi...@apache.org>]

AAfghahi commented on a change in pull request #14741:
URL: https://github.com/apache/superset/pull/14741#discussion_r644008255



##########
File path: superset-frontend/src/SqlLab/components/ResultSet.tsx
##########
@@ -526,34 +526,32 @@ export default class ResultSet extends React.PureComponent<
     const { results, rows, queryLimit, limitingFactor } = this.props.query;
     let limitMessage;
     const limitReached = results?.displayLimitReached;
-    const isAdmin = !!this.props.user?.roles.Admin;
     const limit = queryLimit || results.query.limit;
+    const isAdmin = !!this.props.user?.roles.Admin;

Review comment:
       I think that makes sense to me, @eschutho what do you think?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org