[jira] [Commented] (CASSANDRA-4609) Add thrift transport factory impl to cassandra-cli

["Pavel Yaskevich (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/CASSANDRA-4609?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13455705#comment-13455705 ] 

Pavel Yaskevich commented on CASSANDRA-4609:
--------------------------------------------

This doesn't look like what I had in mind, the reason to have transport factory is to remove all the branching we already have - e.g. if (sessionState.framed) or socket considerations, and let pluggable transport factory to generate the correct transport in one line. 

I think it should be done in a way that allows users to pass --transport-factory as a parameter to the cassandra-cli script or if it wasn't given use some default factory. So actually if you want SSL enabled sockets, you can pass it something like TThriftSSLFactory which on getTransport() would generate SSL TSocket and return it as TTransport without checking anything directly in CliMain. What do you think, Jake?
                
> Add thrift transport factory impl to cassandra-cli
> --------------------------------------------------
>
>                 Key: CASSANDRA-4609
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-4609
>             Project: Cassandra
>          Issue Type: Sub-task
>            Reporter: T Jake Luciani
>            Assignee: Jason Brown
>             Fix For: 1.1.6
>
>         Attachments: 0003-CASSANDRA-4609-add-thrift-transport-factory-support-.patch
>
>


--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira