You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@calcite.apache.org by GitBox <gi...@apache.org> on 2019/10/30 01:18:39 UTC

[GitHub] [calcite] yanlin-Lynn commented on issue #1396: [CALCITE-3278] Simplify the use to translate RexNode to Expression for evaluating.

yanlin-Lynn commented on issue #1396: [CALCITE-3278] Simplify the use to translate RexNode to Expression for evaluating.
URL: https://github.com/apache/calcite/pull/1396#issuecomment-547697638
 
 
   > looks good. can we have a test regarding translate `aggregation` functions ? that will be more intuitive.
   
   Thanks for reviewing @zinking . But I don't get what `translate aggregation functions` mean. 
   Do you mean to test translate some for function like `COUNT` or do you mean to test the `forAggregation` of `RexToLixTranslator`.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services