You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@mxnet.apache.org by GitBox <gi...@apache.org> on 2019/03/28 13:17:53 UTC

[GitHub] [incubator-mxnet] lebeg commented on a change in pull request #14550: Do not touch GPU 0 during ReleaseAll

lebeg commented on a change in pull request #14550: Do not touch GPU 0 during ReleaseAll
URL: https://github.com/apache/incubator-mxnet/pull/14550#discussion_r269995425
 
 

 ##########
 File path: src/storage/pooled_storage_manager.h
 ##########
 @@ -54,10 +54,11 @@ class GPUPooledStorageManager final : public StorageManager {
   /*!
    * \brief Default constructor.
    */
-  GPUPooledStorageManager() {
+  GPUPooledStorageManager(int dev_id) {
 
 Review comment:
   Maybe pass the context instead? And call it creation_ or initial_context? And maybe add a short explanation to the parameters documentation?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services