You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@thrift.apache.org by "Michael Stockton (JIRA)" <ji...@apache.org> on 2009/04/02 18:03:13 UTC
[jira] Created: (THRIFT-421) underscore output file names and
require file statements
underscore output file names and require file statements
--------------------------------------------------------
Key: THRIFT-421
URL: https://issues.apache.org/jira/browse/THRIFT-421
Project: Thrift
Issue Type: Improvement
Components: Compiler (Ruby), Library (Ruby)
Reporter: Michael Stockton
Assignee: Michael Stockton
Priority: Trivial
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Closed: (THRIFT-421) underscore output file names and
require file statements
Posted by "Kevin Clark (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/THRIFT-421?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Kevin Clark closed THRIFT-421.
------------------------------
Resolution: Fixed
Fix Version/s: 0.1
Ok, pushed in 762907, and noted in the changelog in r762908.
> underscore output file names and require file statements
> --------------------------------------------------------
>
> Key: THRIFT-421
> URL: https://issues.apache.org/jira/browse/THRIFT-421
> Project: Thrift
> Issue Type: Improvement
> Components: Compiler (Ruby), Library (Ruby)
> Reporter: Michael Stockton
> Assignee: Michael Stockton
> Priority: Trivial
> Fix For: 0.1
>
> Attachments: thrift-421-v2.patch, thrift-421-v3.patch, thrift-421-v4.patch, thrift-421.patch
>
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (THRIFT-421) underscore output file names and
require file statements
Posted by "Michael Stockton (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/THRIFT-421?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Michael Stockton updated THRIFT-421:
------------------------------------
Attachment: thrift-421.patch
> underscore output file names and require file statements
> --------------------------------------------------------
>
> Key: THRIFT-421
> URL: https://issues.apache.org/jira/browse/THRIFT-421
> Project: Thrift
> Issue Type: Improvement
> Components: Compiler (Ruby), Library (Ruby)
> Reporter: Michael Stockton
> Assignee: Michael Stockton
> Priority: Trivial
> Attachments: thrift-421.patch
>
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (THRIFT-421) underscore output file names and
require file statements
Posted by "Michael Stockton (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/THRIFT-421?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Michael Stockton updated THRIFT-421:
------------------------------------
Attachment: thrift-421-v2.patch
Updated to match changes coming in THRIFT-276.
> underscore output file names and require file statements
> --------------------------------------------------------
>
> Key: THRIFT-421
> URL: https://issues.apache.org/jira/browse/THRIFT-421
> Project: Thrift
> Issue Type: Improvement
> Components: Compiler (Ruby), Library (Ruby)
> Reporter: Michael Stockton
> Assignee: Michael Stockton
> Priority: Trivial
> Attachments: thrift-421-v2.patch, thrift-421.patch
>
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (THRIFT-421) underscore output file names and
require file statements
Posted by "Michael Stockton (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/THRIFT-421?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Michael Stockton updated THRIFT-421:
------------------------------------
Attachment: thrift-421-v4.patch
Updated to handle compiler changes made in thrift-267-v8.patch.
> underscore output file names and require file statements
> --------------------------------------------------------
>
> Key: THRIFT-421
> URL: https://issues.apache.org/jira/browse/THRIFT-421
> Project: Thrift
> Issue Type: Improvement
> Components: Compiler (Ruby), Library (Ruby)
> Reporter: Michael Stockton
> Assignee: Michael Stockton
> Priority: Trivial
> Attachments: thrift-421-v2.patch, thrift-421-v3.patch, thrift-421-v4.patch, thrift-421.patch
>
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (THRIFT-421) underscore output file names and
require file statements
Posted by "Bryan Duxbury (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/THRIFT-421?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12695502#action_12695502 ]
Bryan Duxbury commented on THRIFT-421:
--------------------------------------
I'd say this patch looks good. We need to note that your require statements are going to break in the changelog though.
> underscore output file names and require file statements
> --------------------------------------------------------
>
> Key: THRIFT-421
> URL: https://issues.apache.org/jira/browse/THRIFT-421
> Project: Thrift
> Issue Type: Improvement
> Components: Compiler (Ruby), Library (Ruby)
> Reporter: Michael Stockton
> Assignee: Michael Stockton
> Priority: Trivial
> Attachments: thrift-421-v2.patch, thrift-421.patch
>
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (THRIFT-421) underscore output file names and
require file statements
Posted by "Kevin Clark (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/THRIFT-421?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12695514#action_12695514 ]
Kevin Clark commented on THRIFT-421:
------------------------------------
Yup, +1 as well.
> underscore output file names and require file statements
> --------------------------------------------------------
>
> Key: THRIFT-421
> URL: https://issues.apache.org/jira/browse/THRIFT-421
> Project: Thrift
> Issue Type: Improvement
> Components: Compiler (Ruby), Library (Ruby)
> Reporter: Michael Stockton
> Assignee: Michael Stockton
> Priority: Trivial
> Attachments: thrift-421-v2.patch, thrift-421.patch
>
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (THRIFT-421) underscore output file names and
require file statements
Posted by "Michael Stockton (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/THRIFT-421?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Michael Stockton updated THRIFT-421:
------------------------------------
Patch Info: [Patch Available]
> underscore output file names and require file statements
> --------------------------------------------------------
>
> Key: THRIFT-421
> URL: https://issues.apache.org/jira/browse/THRIFT-421
> Project: Thrift
> Issue Type: Improvement
> Components: Compiler (Ruby), Library (Ruby)
> Reporter: Michael Stockton
> Assignee: Michael Stockton
> Priority: Trivial
> Attachments: thrift-421.patch
>
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (THRIFT-421) underscore output file names and
require file statements
Posted by "Michael Stockton (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/THRIFT-421?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Michael Stockton updated THRIFT-421:
------------------------------------
Attachment: thrift-421-v3.patch
> underscore output file names and require file statements
> --------------------------------------------------------
>
> Key: THRIFT-421
> URL: https://issues.apache.org/jira/browse/THRIFT-421
> Project: Thrift
> Issue Type: Improvement
> Components: Compiler (Ruby), Library (Ruby)
> Reporter: Michael Stockton
> Assignee: Michael Stockton
> Priority: Trivial
> Attachments: thrift-421-v2.patch, thrift-421-v3.patch, thrift-421.patch
>
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (THRIFT-421) underscore output file names and
require file statements
Posted by "Michael Stockton (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/THRIFT-421?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Michael Stockton updated THRIFT-421:
------------------------------------
Attachment: thrift-421-v4-testrb.patch
An additional small update to test/rb so make check runs.
> underscore output file names and require file statements
> --------------------------------------------------------
>
> Key: THRIFT-421
> URL: https://issues.apache.org/jira/browse/THRIFT-421
> Project: Thrift
> Issue Type: Improvement
> Components: Compiler (Ruby), Library (Ruby)
> Reporter: Michael Stockton
> Assignee: Michael Stockton
> Priority: Trivial
> Fix For: 0.1
>
> Attachments: thrift-421-v2.patch, thrift-421-v3.patch, thrift-421-v4-testrb.patch, thrift-421-v4.patch, thrift-421.patch
>
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.