[GitHub] [airflow] potiuk commented on pull request #20677: Opentelemetry instrumentation

[GitBox <gi...@apache.org>]

potiuk commented on pull request #20677:
URL: https://github.com/apache/airflow/pull/20677#issuecomment-1008327884


   Hey Melodie - I pushed a fixup - I managed to find and workaround the problems:
   
   It was not easy and required to know quite a bit of Airflow internals:
   
   * we needed to run gunicorn inside Airflow with `opentelemetry-instrument" not only airflow
   * open-telemetry does not seem to run properly with gunicorn by default, so even if application is properly instrumented (which happens automatically by adding opentelemetry-instrunment to gunicorn), the fork model of Gunicorn is such that it does not really work well with open-telemetry without the workaround documented here:
   
   https://opentelemetry-python.readthedocs.io/en/latest/examples/fork-process-model/README.html
   
   My chnge adds this workaround and produces this :tada: :tada: 
   
   ![Screenshot from 2022-01-09 17-09-32](https://user-images.githubusercontent.com/595491/148690714-415d2441-89bb-4b11-9639-3bd260f6a0bf.png)
   
   Try it and we can talk about next steps :)
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org