You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@beam.apache.org by GitBox <gi...@apache.org> on 2020/10/29 17:20:58 UTC

[GitHub] [beam] robertwb commented on a change in pull request #13177: Sort stages according to data edges as well as must-follows.

robertwb commented on a change in pull request #13177:
URL: https://github.com/apache/beam/pull/13177#discussion_r514434037



##########
File path: sdks/python/apache_beam/runners/portability/fn_api_runner/translations.py
##########
@@ -1702,13 +1702,26 @@ def sort_stages(stages, pipeline_context):
   seen = set()  # type: Set[Stage]
   ordered = []
 
+  producers = {
+      pcoll: stage
+      for stage in all_stages for t in stage.transforms

Review comment:
       This should be sufficient. Generally the subtransform structure is not preserved when dealing with stages (and is simply reconstructed later). 




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org