You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@dolphinscheduler.apache.org by GitBox <gi...@apache.org> on 2021/01/24 23:00:57 UTC
[GitHub] [incubator-dolphinscheduler] codecov-io commented on pull request #4548: [Improvement][service] Refactor service module to fix code smell
codecov-io commented on pull request #4548:
URL: https://github.com/apache/incubator-dolphinscheduler/pull/4548#issuecomment-766455064
# [Codecov](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/4548?src=pr&el=h1) Report
> Merging [#4548](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/4548?src=pr&el=desc) (a98cc11) into [dev](https://codecov.io/gh/apache/incubator-dolphinscheduler/commit/829fdb52c1769030113b450b0b98ffecfe3693f8?el=desc) (829fdb5) will **decrease** coverage by `0.00%`.
> The diff coverage is `54.71%`.
[](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/4548?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## dev #4548 +/- ##
============================================
- Coverage 44.73% 44.73% -0.01%
- Complexity 3339 3342 +3
============================================
Files 528 530 +2
Lines 22832 22839 +7
Branches 2669 2669
============================================
+ Hits 10213 10216 +3
- Misses 11698 11704 +6
+ Partials 921 919 -2
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/4548?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...plugin/alert/dingtalk/DingTalkParamsConstants.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/4548/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1hbGVydC1wbHVnaW4vZG9scGhpbnNjaGVkdWxlci1hbGVydC1kaW5ndGFsay9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZG9scGhpbnNjaGVkdWxlci9wbHVnaW4vYWxlcnQvZGluZ3RhbGsvRGluZ1RhbGtQYXJhbXNDb25zdGFudHMuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...cheduler/plugin/alert/dingtalk/DingTalkSender.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/4548/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1hbGVydC1wbHVnaW4vZG9scGhpbnNjaGVkdWxlci1hbGVydC1kaW5ndGFsay9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZG9scGhpbnNjaGVkdWxlci9wbHVnaW4vYWxlcnQvZGluZ3RhbGsvRGluZ1RhbGtTZW5kZXIuamF2YQ==) | `45.00% <0.00%> (ø)` | `9.00 <0.00> (ø)` | |
| [...inscheduler/plugin/alert/email/EmailConstants.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/4548/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1hbGVydC1wbHVnaW4vZG9scGhpbnNjaGVkdWxlci1hbGVydC1lbWFpbC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZG9scGhpbnNjaGVkdWxlci9wbHVnaW4vYWxlcnQvZW1haWwvRW1haWxDb25zdGFudHMuamF2YQ==) | `87.50% <0.00%> (-5.84%)` | `1.00 <0.00> (ø)` | |
| [...eduler/plugin/alert/email/MailParamsConstants.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/4548/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1hbGVydC1wbHVnaW4vZG9scGhpbnNjaGVkdWxlci1hbGVydC1lbWFpbC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZG9scGhpbnNjaGVkdWxlci9wbHVnaW4vYWxlcnQvZW1haWwvTWFpbFBhcmFtc0NvbnN0YW50cy5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [.../dolphinscheduler/plugin/alert/script/OSUtils.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/4548/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1hbGVydC1wbHVnaW4vZG9scGhpbnNjaGVkdWxlci1hbGVydC1zY3JpcHQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvcGx1Z2luL2FsZXJ0L3NjcmlwdC9PU1V0aWxzLmphdmE=) | `33.33% <0.00%> (ø)` | `1.00 <0.00> (ø)` | |
| [...ler/plugin/alert/script/ScriptParamsConstants.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/4548/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1hbGVydC1wbHVnaW4vZG9scGhpbnNjaGVkdWxlci1hbGVydC1zY3JpcHQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvcGx1Z2luL2FsZXJ0L3NjcmlwdC9TY3JpcHRQYXJhbXNDb25zdGFudHMuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...uler/plugin/alert/wechat/WeChatAlertConstants.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/4548/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1hbGVydC1wbHVnaW4vZG9scGhpbnNjaGVkdWxlci1hbGVydC13ZWNoYXQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvcGx1Z2luL2FsZXJ0L3dlY2hhdC9XZUNoYXRBbGVydENvbnN0YW50cy5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...lugin/alert/wechat/WeChatAlertParamsConstants.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/4548/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1hbGVydC1wbHVnaW4vZG9scGhpbnNjaGVkdWxlci1hbGVydC13ZWNoYXQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvcGx1Z2luL2FsZXJ0L3dlY2hhdC9XZUNoYXRBbGVydFBhcmFtc0NvbnN0YW50cy5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...n/alert/wechat/exception/WeChatAlertException.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/4548/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1hbGVydC1wbHVnaW4vZG9scGhpbnNjaGVkdWxlci1hbGVydC13ZWNoYXQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvcGx1Z2luL2FsZXJ0L3dlY2hhdC9leGNlcHRpb24vV2VDaGF0QWxlcnRFeGNlcHRpb24uamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...g/apache/dolphinscheduler/spi/utils/JSONUtils.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/4548/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1zcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvc3BpL3V0aWxzL0pTT05VdGlscy5qYXZh) | `27.27% <ø> (ø)` | `3.00 <0.00> (ø)` | |
| ... and [11 more](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/4548/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/4548?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/4548?src=pr&el=footer). Last update [829fdb5...a98cc11](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/4548?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org