You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@beam.apache.org by "olehborysevych (via GitHub)" <gi...@apache.org> on 2023/03/16 12:38:38 UTC

[GitHub] [beam] olehborysevych commented on a diff in pull request #25793: Automation: Tour of Beam infrastructure deployment

olehborysevych commented on code in PR #25793:
URL: https://github.com/apache/beam/pull/25793#discussion_r1138591675


##########
learning/tour-of-beam/frontend/lib/pages/tour/state.dart:
##########
@@ -213,12 +213,12 @@ class TourNotifier extends ChangeNotifier with PageStateMixin<void> {
     return playgroundController;
   }
 
-  @override
-  void dispose() {
+@override
+  Future<void> dispose() async {

Review Comment:
   @nausharipov could you please look if you ok with this change here. We hope that one of Frontend PRs will be merged first and this will go away



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org